https://forge.joomlapolis.com/https://forge.joomlapolis.com/favicon.ico?17095821032020-08-14T17:35:22ZJoomlapolis forgeCB Paid Subscriptions - Bug #8121: Free lifetime plans display a state of Expired Activehttps://forge.joomlapolis.com/issues/8121?journal_id=208982020-08-14T17:35:22Zkrileonkrileon@joomlapolis.com
<ul></ul><p>Appears to be due to the validity date output. The below is responsible for validity output but it's already outputting an empty string.</p>
<p>IN: components/com_comprofiler/plugin/user/plug_cbpaidsubscriptions/views/something.php<br />ON: Line 118</p> CB Paid Subscriptions - Bug #8121: Free lifetime plans display a state of Expired Activehttps://forge.joomlapolis.com/issues/8121?journal_id=208992020-08-14T17:39:23Zkrileonkrileon@joomlapolis.com
<ul></ul><p>Looks like <code>$viewModel->validity</code> gets altered sometime after line 118 and goes from null to Expired. Can't make any sense of it.</p> CB Paid Subscriptions - Bug #8121: Free lifetime plans display a state of Expired Activehttps://forge.joomlapolis.com/issues/8121?journal_id=209002020-08-14T17:44:51Zkrileonkrileon@joomlapolis.com
<ul></ul><p>Ok, it's a bug in getFormattedValidityRemaining introduced in commit 6b3313ed.</p>
<p>IN: components/com_comprofiler/plugin/user/plug_cbpaidsubscriptions/products/usersubscription/cbpaidUsersubscriptionRecord.php<br />ON: Line 1205</p>
<p>That function expects a database formatted datetime for expiry_date, but free lifetime is providing null causing the if checks to not work correctly. Looks like it just needs to handle null case like other functions in that class.</p> CB Paid Subscriptions - Bug #8121: Free lifetime plans display a state of Expired Activehttps://forge.joomlapolis.com/issues/8121?journal_id=209012020-08-14T18:04:34Zkrileonkrileon@joomlapolis.com
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Resolved</i></li><li><strong>Assignee</strong> changed from <i>beat</i> to <i>krileon</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Fixed in MR !205</p>
<p>Few locations weren't handling null expiry date which is the expiry date for lifetime subscriptions.</p> CB Paid Subscriptions - Bug #8121: Free lifetime plans display a state of Expired Activehttps://forge.joomlapolis.com/issues/8121?journal_id=212742020-12-10T01:38:18Zbeat
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>