Bug #1499
closed
Need FBC Language strings for cbteamplugins_language.php
100%
Files
Updated by krileon about 14 years ago
- File facebook_lang.txt facebook_lang.txt added
- Status changed from Assigned to Resolved
- Assignee changed from krileon to beat
- % Done changed from 0 to 80
All language strings prepared and in attached file.
Updated by beat about 14 years ago
- Assignee changed from beat to krileon
- % Done changed from 80 to 70
Language strings should not have formatting included normally.
Removed in CB languages the space before following texts and committed to CB 1.2.2:
' Please change your password from profile edit before unlinking to allow further login after unlinked.' => ' Please change your password from profile edit before unlinking to allow further login after unlinked.',
' Please change your email from profile edit before unlinking to allow further login after unlinked.' => ' Please change your email from profile edit before unlinking to allow further login after unlinked.',
' Would you like to do this now?' => ' Would you like to do this now?',
Please update FBC accordingly.
Updated by krileon about 14 years ago
This would remove spacing from the pop-up so you'd have "Please change your password from profile edit before unlinking to allow further login after unlinked.Please change your email from profile edit before unlinking to allow further login after unlinked.Would you like to do this now?" instead of "Please change your password from profile edit before unlinking to allow further login after unlinked. Please change your email from profile edit before unlinking to allow further login after unlinked. Would you like to do this now?"; will fix in code, but there a reason for not allowing spaces? Instead of a space is it safe to use a character string (string for non-breaking space)?
Updated by krileon about 14 years ago
- Status changed from Assigned to Feedback
- Assignee changed from krileon to beat
Updated by beat about 14 years ago
- Assignee changed from beat to krileon
- Translations are not easy and spaces are tricky
- You could need same string without space somewhere else
- Generally you should have full sentences that when you append, you append with spaces and formatting outside.
- E.g. of use where spaces interfer at end or begin: if you format in html in underline or background coloring, or link, then you have the space at begin or end underlined/colored: not pretty
Updated by beat about 14 years ago
also small thing here:
'Synced from Facebook; do not change here, but at Facebook as: ' => 'Synced from Facebook; do not change here, but at Facebook as: ',
You are appending something obviously
in some languages, appending can be odd
better would be:
'Synced from Facebook; do not change here, but at Facebook as: %s' => 'Synced from Facebook; do not change here, but at Facebook as: %s',
and use sprintf in code ;)We decided to change it.
Updated by krileon about 14 years ago
- Status changed from Feedback to Resolved
- Assignee changed from krileon to beat
- % Done changed from 70 to 80
Commit r831
Updated by krileon about 14 years ago
- Status changed from Resolved to Closed
- % Done changed from 80 to 100