Project

General

Profile

Actions

Bug #2851

closed

paging fails if limitbox is disabled as the JS needs the input

Added by krileon almost 11 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
30 September 2011
Due date:
% Done:

100%

Estimated time:

Description

When limitbox is disabled the paging will fail because it needs the input as part of the submit. So a hidden input still must be rendered to ensure it continues to function even if limitbox was disabled.

Actions #1

Updated by krileon almost 11 years ago

  • Subject changed from paging fails if limitbox is disabled as the JS needs to input to paging fails if limitbox is disabled as the JS needs the input
Actions #2

Updated by krileon almost 11 years ago

Fix is to remove the if/else statement on executing the function or not, but instead using the following.

getLimitBox( false )

The above would render only the hidden input, IF statement would tell it true or false.

Actions #3

Updated by beat almost 11 years ago

Actually:

- you should not display the paging at all in front-end if there is only 1 page. Just clutters the display.
- reply comments should not have searchboxes, as it's confusing to have 2 searchboxes for 1 thread.

Actions #4

Updated by krileon almost 11 years ago

- you should not display the paging at all in front-end if there is only 1 page. Just clutters the display.

Agreed, reviewing for implementation.

- reply comments should not have searchboxes, as it's confusing to have 2 searchboxes for 1 thread.

Don't agree, should be up to the admin as searchbox for replies can be disabled on an install by install basis through GJ configuration.

Actions #5

Updated by krileon almost 11 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by krileon over 10 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF