Project

General

Profile

Actions

Bug #6976

closed

If rows are removed during trigger usage more button still shows

Added by krileon over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Target version:
Start date:
14 January 2018
Due date:
% Done:

100%

Estimated time:

Description

If there are more than 1 page worth of activity entries and enough get removed to reduce it to 1 page then the more button still shows. The limit check for paging to display the more button could be improved to better account for this.

Actions #1

Updated by krileon over 6 years ago

Note this is NOT a new bug. It happened with previous paging behavior as well it just wasn't as obvious since the new paging ONLY grabs current page + 1 instead of the entire count.

Actions #2

Updated by krileon over 6 years ago

  • % Done changed from 0 to 50

Partially resolved for some scenarios. Still needs further fixing.

Actions #3

Updated by krileon over 6 years ago

Future paging is needed to resolve this. If rows are removed the next page needs to be requested (count only!). This can then be cached and sent with the next page request so we don't need to do that count again. This does potentially increase query count by 1 more, but it's a fast 1-2ms query so is unnoticed.

Actions #4

Updated by krileon over 6 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 50 to 100
Actions #5

Updated by krileon over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF