Project

General

Profile

Actions

Bug #6987

closed

Hidden rows that don't exist cause performance drop

Added by krileon over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
17 January 2018
Due date:
% Done:

100%

Estimated time:

Description

When there's hidden rows for activity that doesn't exist it results in performance drop when outputting the hidden activity page.

Actions #1

Updated by krileon over 6 years ago

Best way to fix this seams to be to change the hidden query to a union usage to combine the 3 hidden type checks. Maybe a new API library should be implemented specifically for handling hidden activity, comments, etc..

Actions #2

Updated by krileon over 6 years ago

Nope, no union needed. Simplify the join to only join the viewing users hidden rows as a LEFT join. Next add the filtering to the WHERE statement directly. Drops the query to 0.02s average.

Actions #3

Updated by krileon over 6 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by krileon over 6 years ago

  • Status changed from Resolved to Assigned
  • % Done changed from 100 to 50
Actions #5

Updated by krileon over 6 years ago

Only fix for this was to indeed use a union of 3 queries to the 3 different hidden types.

Actions #6

Updated by krileon over 6 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 50 to 100
Actions #7

Updated by krileon over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF