Project

General

Profile

Bug #8078

Substitution [SUBSCRIPTION_VALIDITY_PERIOD_REMAINING] substitutes to the total period of the current subscription instead of the remaining time

Added by beat 4 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Start date:
29 June 2020
Due date:
% Done:

100%

Estimated time:

Description

https://www.joomlapolis.com/forum/255-developer-members-support/242670-subscription-validity-period-remaining-generating-wrong-value#319359

Using this substitution string in the CBSubs Mailer returns the total subscription validity period, not the validity period remaining.

I defined a test mailer as "90 days before" Subscription expiry date, on all my annual (one year) plans
The email subject:

[SUBSCRIPTION_EXPIRY_DATE] - [SUBSCRIPTION_VALIDITY_PERIOD_REMAINING]

The [SUBSCRIPTION_VALIDITY_PERIOD_REMAINING] values were all "1 year" - not the difference between the expiration date and today's date, which is what I expected.

Confirmed, was always so.

Should probably be renamed into [SUBSCRIPTION_VALIDITY_PERIOD] and see how we can have a reasonable time-left display for [SUBSCRIPTION_VALIDITY_PERIOD_REMAINING].


Related issues

Related to CB Paid Subscriptions - Feature proposal #8079: Internationalization: Better pluralization of time-periodsResolved2020-06-30

History

#1 Updated by beat 4 months ago

  • Description updated (diff)

#2 Updated by beat 4 months ago

#3 Updated by beat 4 months ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Fixed in MR !200 with commit 6b3313ed3a220f2a9fe8cf28a0bf64ac0fc6cc05

Also available in: Atom PDF