Project

General

Profile

Actions

Feature proposal #8664

open

Improve several core asset usages

Added by krileon 4 months ago. Updated 3 months ago.

Status:
Assigned
Priority:
Normal
Assignee:
Target version:
Start date:
11 August 2021
Due date:
% Done:

0%

Estimated time:

Description

Several core activity assets are being poorly used. Mainly commented on and liked type activity. For example when a photo is uploaded to CB Gallery then it being a single photo means comments, likes, etc.. SHOULD be attached directly to the photo. This means commenting on it and generating a commented on activity entry should ALSO be attached directly to the photo. This however isn't the case. Example as follows.

groupjive.group.GROUP_ID.gallery.photos.PHOTO_ID

This is a gallery photo upload to a GJ group. Now commenting on it would generate the following comment activity.

activity.ACTIVITY_ID

This is WRONG. It should be as follows.

groupjive.group.GROUP_ID.gallery.photos.PHOTO_ID.comment

This is a continuation of #8009 where it was decided major structure rewrites aren't necessary and that several core assets are fine (e.g. blog assets).

Actions #1

Updated by krileon 4 months ago

Several object verbs should probably also be improved. Example as follows.

groupjive.group.GROUP_ID.gallery.photos.PHOTO_ID.comment

Changed to the following.

groupjive.group.GROUP_ID.gallery.photos.PHOTO_ID.comment.COMMENT_ID

This would let us know what comment is associated with the activity. Might not be possible to migrate the existing usages though.

Actions #2

Updated by krileon 3 months ago

Plugin assets could use some improvements as well. Specifically CB GroupJive and CB Gallery. These can be safely updated to the following.

FROM: groupjive.group.GROUP_ID
TO: group.GROUP_ID

FROM: gallery.photos.PHOTO_ID
TO: gallery.MEDIA_ID

It's not necessary to prefix GJ and it's not necessary to have type for CB Gallery. This would give shorter assets where possible. Example as follows.

OLD: groupjive.group.GROUP_ID.gallery.photos.PHOTO_ID
NEW: group.GROUP_ID.gallery.MEDIA_ID

Actions #3

Updated by krileon 3 months ago

Change profile.PROFILE_ID to user.USER_ID. This will prepare the asset for future standalone extension usage.

Actions #4

Updated by krileon 3 months ago

Change the long "connection" verb to just "conn".

Actions

Also available in: Atom PDF