Project

General

Profile

Actions

Bug #1450

closed

Add warning in edit mode to sync fields

Added by nant about 14 years ago. Updated about 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
12 February 2010
Due date:
% Done:

100%

Estimated time:

Description

[5:23:24 μμ] Nicholas G. Antimisiaris: question
[5:23:38 μμ] Nicholas G. Antimisiaris: if i login using twitter the image is synced
[5:23:42 μμ] Nicholas G. Antimisiaris: small of course
[5:23:57 μμ] Nicholas G. Antimisiaris: if i then update my image on my cb profile page - will it stick?
[5:24:11 μμ] Kyle (krileon): will what stick?
[5:24:20 μμ] Kyle (krileon): the image you just uploaded?
[5:24:25 μμ] Nicholas G. Antimisiaris: yes
[5:24:30 μμ] Kyle (krileon): yup it'll stay
[5:24:50 μμ] Nicholas G. Antimisiaris: so it wont get over-ridden next time syncronization takes place?
[5:24:55 μμ] Kyle (krileon): wait, no code will over-write it
[5:25:19 μμ] Nicholas G. Antimisiaris: hmm -
[5:25:38 μμ] Kyle (krileon): same applies to things like firstname, etc..
[5:26:23 μμ] Kyle (krileon): change your password and login via joomla instead of twitter.. logging in via twitter or facebook is supposed to keep them in sync :P
[5:27:04 μμ] Beat: means it will be overwritten by twitter ?
[5:27:20 μμ] Beat: or will it overwrite twitter ? :D
[5:27:25 μμ | Edited 5:27:35 μμ] Kyle (krileon): if you upload an avatar and it resyncs.. yes twitters will overwrite it
[5:27:50 μμ] Beat: hm
[5:28:43 μμ] Nicholas G. Antimisiaris: ok did the following on tafix:
+ signed up using twitter
+ uploaded a new profile image on my CB profile which was put in pending approval status
+ unlinked twitter account
+ new image previously in pending state appears to be automatically accepted
[5:28:58 μμ] Kyle (krileon): isn't that the point though to keep them synchronize.. how would we then handle it if user changed twitter avatar and logged in.. should we overwrite their uploaded avatar then?
[5:29:09 μμ] Kyle (krileon): nick, no i just approved your image lol
[5:29:20 μμ] Nicholas G. Antimisiaris: ah - ok
[5:29:47 μμ] Beat: you may want to add a remark in user-profile edit at fields-edit-level (like privacy plugin does) a remark like "Synced from Twitter" and/or "Synced from Facebook: do not change here, but at Facebook"
[5:30:06 μμ] Beat: only for fields synced by the plugin
[5:30:07 μμ] Nicholas G. Antimisiaris: good idea beat
[5:30:25 μμ] Nicholas G. Antimisiaris: because the user is allowed to update - might as well warn him
[5:30:25 μμ] Beat: you can add to forge as FR if Kyle agrees ;)
[5:30:31 μμ] Kyle (krileon): sounds good
[5:30:36 μμ] Nicholas G. Antimisiaris: ok
[5:31:10 μμ] Beat: oh btw, Kyle, not for Forge: but you may want to sanitize the fields synced from Twitter/Facebook using cbGetParam
[5:31:12 μμ] Nicholas G. Antimisiaris: 2 separate issues - 1 twitter - 1 fb?
[5:31:17 μμ] Beat: yes
[5:31:29 μμ] Beat: or just FBC
[5:31:35 μμ] Beat: we know twitter follows ;)

Actions #1

Updated by krileon about 14 years ago

  • Status changed from New to Resolved
  • Assignee set to beat
  • % Done changed from 0 to 80

Commit r773

Actions #2

Updated by krileon about 14 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 80 to 100
Actions #3

Updated by beat about 14 years ago

  • Target version set to 1.0 RC1
Actions

Also available in: Atom PDF