Incubator » CB GroupJive

Class file is (module) and can be loaded externally, wouldn't extending the class by cbPluginHandler cause problems? Used queries to build object so can be used completely externally.

$_PLUGINS has this method:

    /**
     * Returns plugin of group $group and element $element
     * @since 1.3
     *
     * @param  string  $group
     * @param  string  $element
     * @return moscomprofilerPlugin  or FALSE if not loaded
     */
    function getLoadedPlugin( $group, $element ) {

For CB tabs, there is no caching in CB 1.4, so for now, database query is ok. CB 2.0 will be different here.

Using results in loading getLoadedPlugin( $group, $element ) and it's class instance, but the params are not prepared and are completely raw. Seams like more overhead to use this function given it loads the entire class instance of CBplug_cbgroupjive when all that is needed is it's database object. In addition to this oddly soon as I remove the query the function no longer returns the plugin object (user plugin group is loaded at top of class file). Another problem is if the plugin is set to Registered, then the $plugin object will be NULL (because access checks are done in loadPluginGroup), which is not desired as the API needs to still be accessible for 3rd party integrations. Proposing upgrading upon CB 2.0 methods implemented and using as current (current usage is cached).

OK then, closing as rejected then :-)