Project

General

Profile

Bug #7911

Direct category SEF URLs stuck in infinite loop

Added by krileon 6 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Target version:
Start date:
03 April 2020
Due date:
% Done:

100%

Estimated time:

Description

URLs to category URLs with a category menu item with SEF enabled can result in an infinite redirect loop, but only if not logged in. Examples as follows.

/janus
/index.php?option=com_comprofiler&view=pluginclass&plugin=cbgroupjive&action=categories&func=show&id=14&Itemid=6613&lang=fr

Logged out = redirect loop
Logged in = redirect to the following

/index.php?option=com_comprofiler&view=pluginclass&plugin=cbgroupjive&action=categories&func=all&Itemid=6613&lang=fr

It's doing this because the Itemid in the redirect is unchanged. In the routing code it's then pulling the menu parameters back in. It then thinks you're just trying to access that menu item all over again. Probably need to add some failsafe code if it sees func value of all.

https://www.joomlapolis.com/forum/255-developer-members-support/242305-groupjive-router?start=6#317571

Not a critical issue since it's an unlikely or odd configuration since the that menu item shouldn't be being used to begin with if the user doesn't have access to that category as menu access should match category access.

History

#1 Updated by krileon 6 months ago

It maybe best to finally stop using pluralized actions for singular action access. Example as follows.

index.php?option=com_comprofiler&view=pluginclass&plugin=cbgroupjive&action=categories&func=show&id=CATEGORY_ID

Becomes the following by changing the action categories to category since we're accessing a category.

index.php?option=com_comprofiler&view=pluginclass&plugin=cbgroupjive&action=category&func=show&id=CATEGORY_ID

For B/C purposes the previous usage would still need to be supported if accessed, but this would prevent the router from getting confused going forward.

#2 Updated by krileon 6 months ago

  • % Done changed from 0 to 50

This is now at least partially fixed to stop the infinite redirect, but the landing page (all categories) will have wrong SEF links for categories within it.

#3 Updated by krileon 5 months ago

This won't be able to be fixed until fixed in CB itself. See #8010

#4 Updated by krileon 5 months ago

  • Status changed from Assigned to Resolved
  • % Done changed from 50 to 100

This is at least fixed in GJ where URLs will properly send the user where they're trying to go. They can still end up routed strangled due to needed improvements in CB for #8010

Also available in: Atom PDF