Actions
Bug #8224
closed
Expired subscriptions login check happens before confirmed/approved check
Description
When logging in with a plan that requires confirmation/approval before payment the checkExpireMe function in onDuringLogin will redirect the user away if "Allow Free Registered Users (without subscriptions)" is not set to "Yes" to accountexpired page and allows collecting payment despite user not being confirmed/approved. This shouldn't be happening. The checkExpireMe check should be done after onDuringLogin behavior is done with its checks.
Updated by krileon about 4 years ago
- Status changed from New to Resolved
- Assignee set to krileon
- % Done changed from 0 to 100
Fixed in MR !208
Updated by beat about 4 years ago
- Assignee changed from krileon to beat
- Target version changed from 4.5.0 to 4.5.1
- % Done changed from 100 to 90
Looking at code there seems to be some edge cases, needing more careful review and tests before merging, so I will continue doing this after 4.5.0 release.
Updated by beat over 3 years ago
- Status changed from Closed to Resolved
- Target version changed from 4.5.1 to 4.5.3
Updated by beat about 3 years ago
- Target version changed from 4.5.3 to 4.6.0
missed that pending one for 4.5.3, moving to 4.6.0.
Actions