Project

General

Profile

Actions

Bug #8241

closed

CB GroupJive gallery comment notification creating with wrong asset

Added by krileon about 4 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
20 November 2020
Due date:
% Done:

100%

Estimated time:

Description

When commenting on a CB Gallery inserted into CB GroupJive and sending a comment notification to the owner of the gallery entry it is creating with the following asset.

activity.ACTIVITY_ID

This should be using the following for example.

groupjive.group.GROUP_ID.gallery.photos.PHOTO_ID

https://www.joomlapolis.com/forum/153-professional-member-support/243192-problem-with-comments-on-groupjive-activity

Actions #1

Updated by krileon about 4 years ago

Comment asset isn't working correctly at all for gallery entries in CB GroupJive. Clicking the gallery entry to open the modal window results in the comments not being linked to the gallery entry at all.

Actions #2

Updated by krileon about 4 years ago

Modal window is using the following asset structure.

gallery.photos.PHOTO_ID

While CB GroupJive activity comments is using the following.

groupjive.group.GROUP_ID.gallery.photos.PHOTO_ID

Actions #3

Updated by krileon about 4 years ago

  • % Done changed from 0 to 50

This is due to several system actions not being asset prefix aware. The regexp for CB Gallery checks is ^gallery\., but that's the old behavior before prefixing. This needs fixed to ^(?:.+\.)?gallery\..

CB Gallery assetSource parsing needs to be made prefix aware.

CB GroupJive needs to skip assetSource parsing if it's a gallery asset since CB Gallery GJ assets are prefixed by GJ.

This will require fixes in CB Auto Actions, CB Gallery, AND CB GroupJive.

This is a result of the poorly designed storage behavior of Asset. Once this is replaced it will be significantly easier to know exactly the WHERE and the WHAT of an activity entry, comment, etc..

Actions #4

Updated by krileon about 4 years ago

  • % Done changed from 50 to 80

CB Gallery Comments and Likes action use a hardcoded Asset of gallery.TYPE.MEDIA_ID. This is a problem for GJ since GJ gallery is prefixed. CB Gallery itself probably needs the same parent behavior that CB Activity has and to pass the behavior onto CB Gallery.

Actions #5

Updated by krileon about 4 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 80 to 100
Actions #6

Updated by krileon about 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF