Project

General

Profile

Actions

Bug #8319

closed

Changing row order with images unreliable

Added by krileon 5 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
29 December 2020
Due date:
% Done:

100%

Estimated time:

Description

Changing the order after enabling reordering when the field group contains an image field fails to move the image to the new row.

Actions #1

Updated by krileon 2 months ago

This will impact any upload based field since that data isn't present in POST to store it again. Need to figure out a behavior that keeps track of what row id a row moved to. Likely have to adjust CB Repeat itself to keep track of that by likely posting an input value that the row moved to a different index.

Actions #2

Updated by krileon 2 months ago

  • % Done changed from 0 to 30

Partially improved due to #8415

Now needs the code to handle sorting before any storage behavior is applied. Basically if something moves from index 2 to index 1 we want to do that move before any save behavior letting us skip any unnecessary save behavior and ensuring the data is correctly moved.

Actions #3

Updated by krileon 2 months ago

  • Status changed from Assigned to Resolved
  • % Done changed from 30 to 100

Field groups will now properly re-index before processing storage behaviors to ensure existing values can't be lost.

Actions #4

Updated by krileon about 2 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF