Project

General

Profile

Actions

Feature proposal #9187

closed

Stripe: prevent payments using stripe recurring if subscription is not within stripes recurring period limits

Added by krileon 11 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
02 June 2023
Due date:
% Done:

100%

Estimated time:

Description

Stripe has the following period limits for subscriptions.

1 year, 12 months, 52 week, or 365 days

If a plan goes over these then it will error. Implement support for instead creating a subscription schedule breaking up the duration so the plan can still be subscribed to. Implement suppressing Stripe as a payment method if it can't possibly be paid using Stripe to prevent accepting payment for a subscription that can't be completed. Completely suppress the button rendering and add fail safe redirect for payment form page as well.

Actions #1

Updated by krileon 11 months ago

There's no real workaround for this. Attempting to use subscription schedules would be more of a hack than anything and risks things going wrong. Schedules are already being used for different price/period durations and adding another layer of schedules onto that would cause odd webhook behavior.

Maybe best to suppress allowing usage of Stripe at time of basket if the durations aren't permitted.

Actions #2

Updated by krileon 11 months ago

  • Subject changed from Stripe: when a subscription surpasses period limits create a subscription schedule breaking up the subscription to Stripe: prevent payments using stripe recurring if subscription is not within stripes recurring period limits
  • Description updated (diff)
Actions #3

Updated by krileon 11 months ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Implemented in MR !317

There's no real viable workaround for Stripe recurring period limits. Instead we'll now suppress Stripe recurring payments button if the period limit isn't valid. It will always prevent access to the payment form if the period limit is invalid. This will prevent CBSubs from trying to collect payment for a payment that can't possibly complete. Admins should be mindful of gateway limitations when configuring recurring payments!

Actions #4

Updated by beat 9 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF