Feature proposal #1707
closed
Insert limit pagination value in urls (needed by SEF extensions)
Description
As per talk with Beat, we'd like C pagination class to insert the "limit" value (number of items per page) in its url. Though it appears to no be used by CB, this will allow SEF extensions to properly calculate page numbers. Currently, only starting item number ("limitstart") is found in the url, similar to what Joomla is doing.
Extensions that use Joomla JPagination class are handled by sh404sef, but as CB use its own pagination class, we cannot override it.
Appropriate code has been discussed with Beat, but you can contact me at shumisha at gmail dot com for details as needed
Updated by beat over 14 years ago
- Target version set to CB 1.2.3
- Estimated time set to 0:18 h
Updated by beat over 14 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 90
Implemented as follows:
In function writePagesLinks($limitstart, $limit, $total,$ue_base_url,$search=null,$prefix='')
Around line 886 of comprofiler.class changed it to:
$limstart_str = '&' . urlencode($prefix) . 'limit=' . (int) $limit . '&'.urlencode($prefix) . 'limitstart=';Could you please confirm that this is the fix you wanted ?
Thanks,
Beat
Committed in r1016.
Updated by shumisha over 14 years ago
Hi Beat
Yes, that's what seems to be working fine in my test!
Yannick
Updated by beat over 14 years ago
- Status changed from Feedback to Closed
- % Done changed from 90 to 100
Cool, thanks, closing.
Updated by beat over 14 years ago
- Subject changed from Insert limit pagination value in urls to Insert limit pagination value in urls (needed by SEF extensions)