Project

General

Profile

Actions

Bug #2306

closed

J1.6: not possible to change Moderator Groups

Added by krileon about 13 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
High
Assignee:
Target version:
Start date:
08 February 2011
Due date:
% Done:

100%

Estimated time:
2:00 h

Description

When saving after changing Moderator Groups it reverts to Super Users. The drop down is also not a multi-select. Will need to be changed to support multiple groups as Administrators and Super Users are not in the same "Parent" so selecting Administrators would NOT include Super Users as moderators.


Files

2306a.patch (991 Bytes) 2306a.patch krileon, 08 February 2011 20:53
2306b.patch (876 Bytes) 2306b.patch krileon, 08 February 2011 20:53

Updated by krileon about 13 years ago

Patch A makes sure the array checked can actually be checked (in_array was failing as gtree was an array of objects). Patch B makes sure Super Users are a Parent of Moderator/Administrator groups (best approach to maintain backwards support).

Actions #2

Updated by beat about 13 years ago

  • Estimated time set to 2:00 h
Actions #3

Updated by beat about 13 years ago

  • Status changed from Resolved to Assigned
  • Assignee changed from beat to krileon
  • % Done changed from 100 to 90

This fixes it partially. No multi-selects are possible.

Committed above patches in r1421 .

Also commented the 2nd unused column on line 402, 420, and 429, as it's loadResultArray()... Please review that.

Actions #4

Updated by krileon about 13 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 90 to 100

Not possible for multi-select and maintaining backwards support. Something to consider for 2.0, but not 1.4.

Actions

Also available in: Atom PDF