Project

General

Profile

Actions

Bug #2436

closed

J1.6: get_user_group_id not returning top most gid

Added by krileon about 13 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
18 March 2011
Due date:
% Done:

100%

Estimated time:
2:00 h

Description

Anywhere get_user_group_id is used within Joomla 1.6 is not returning the top most GID. This causes for example someone that is in a custom group of Group 1 AND Registered always returns as Registered instead of Group 1 (as seen in database in _users).

https://www.joomlapolis.com/forum/154-advanced-members-support/157943-list-access-limited-to-usergroup-not-working


Files

2436.patch (1.68 KB) 2436.patch krileon, 18 March 2011 19:53

Related issues 1 (0 open1 closed)

Blocks CB - Bug #2437: J1.6: Users lists: public and backend GIDs in access check hardcodedClosedbeat18 March 2011

Actions
Actions #1

Updated by krileon about 13 years ago

  • Subject changed from J1.6: admin usergroup diff in userlist group array hardcoded to 1.5 to J1.6: get_user_group_id not returning top most gid
Actions #2

Updated by krileon about 13 years ago

  • File 2436.patch 2436.patch added
  • Status changed from New to Resolved
  • Assignee set to beat
  • % Done changed from 0 to 100
Actions #3

Updated by beat over 12 years ago

  • Target version set to CB 1.7
Actions #4

Updated by beat over 12 years ago

  • Estimated time set to 2:00 h
Actions #5

Updated by beat over 12 years ago

  • Status changed from Resolved to Assigned
  • Assignee changed from beat to krileon
  • % Done changed from 100 to 50

we need to have same keys implemented for all CMS types.

Can you please submit a new patch that is also valid for all joomla 1.0,1.5 and Mambos 4.5 and 4.6 ?

Actions #6

Updated by krileon over 12 years ago

  • Status changed from Assigned to Resolved
  • Assignee changed from krileon to beat
  • % Done changed from 50 to 100

Patch is valid for Mambo and J1.0. Please see below group mappings.

Joomla 1.6
1 Public
2 Registered
3 Author
4 Editor
5 Publisher
6 Manager
7 Administrator
8 Super Users

Joomla 1.5
17 ROOT
28 USERS
29 Public Frontend
18 Registered
19 Author
20 Editor
21 Publisher
30 Public Backend
23 Manager
24 Administrator
25 Super Administrator

Joomla 1.0
17 ROOT
28 USERS
29 Public Frontend
18 Registered
19 Author
20 Editor
21 Publisher
30 Public Backend
23 Manager
24 Administrator
25 Super Administrator

Mambo
17 ROOT
28 USERS
29 Public Frontend
18 Registered
19 Author
20 Editor
21 Publisher
30 Public Backend
23 Manager
24 Administrator
25 Super Administrator

Only Joomla 1.6 (and greater) has a different structure which is covered with if ( checkJversion() >= 2 ) { and the } else { taking care of j1.5, j1.0, and mambo.

Actions #7

Updated by beat over 12 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from beat to krileon
  • % Done changed from 100 to 90

Patch applied in r1490.

Agree with the fix for the bug.

But don't understand the need for the change in mapGroupNamesToValues() :
Do we have uses of Root, Public and Backend in joomla < 1.6 ?

Actions #8

Updated by beat over 12 years ago

  • Status changed from Feedback to Closed
  • Assignee changed from krileon to beat

Ah, understood where it is. It is now used in fix of #2437 .

However, in the way it is used to fix #2437, it might fail on joomla 1.6. So the new keys Root, Public and Backend need to be added in joomla < 1.6, but then ignored properly in the output.

r1491 implements that regression fix. And allows to close this bug.

Actions #9

Updated by beat over 12 years ago

  • % Done changed from 90 to 100
Actions

Also available in: Atom PDF