Project

General

Profile

Actions

Feature proposal #3070

closed

J2.5: language filter support for CB menus and Itemid's

Added by krileon over 12 years ago. Updated about 12 years ago.

Status:
Closed
Priority:
High
Assignee:
Target version:
Start date:
05 December 2011
Due date:
% Done:

100%

Estimated time:
2:00 h

Description

When using Joomlas language filtering and multilingual menus CB is grabbing the first Itemid for a URL it sees and it could very well always be the English menu item resulting in other languages always seeing menu items in English.

https://www.joomlapolis.com/forum/153-professional-member-support/184420-menu-disappears-in-webkit-browsers


Files

3070.patch (1.08 KB) 3070.patch krileon, 07 February 2012 16:04
Actions #1

Updated by beat over 12 years ago

  • Target version set to CB 1.8
  • Estimated time set to 2:00 h
Actions #3

Updated by beat about 12 years ago

  • Priority changed from Normal to High
Actions #4

Updated by beat about 12 years ago

  • Assignee set to krileon
Actions #5

Updated by krileon about 12 years ago

  • File 3070.patch 3070.patch added
  • Status changed from New to Resolved
  • Assignee changed from krileon to beat
  • % Done changed from 0 to 100

Proposed fix is for J1.6+ only and it'll check your lang tag against the database row to ensure the database row is your lang tag or is for all languages before pulling the itemid, will prevent russian language for example pulling english language menu itemid (which would give a 404 error). The only possible problem is the lang tags are use defined in Extensions > Language Manager > Content.. so if the user doesn't supply as ru-RU for example it won't match, but not much we can do to avoid that except check the GET for the lang then check that against the database for its tag then check its tag against the menu link and that's a lot of overhead per page load for Itemid.

Actions #6

Updated by beat about 12 years ago

  • Subject changed from J1.7: language filter support to J2.5: language filter support for CB menus and Itemid's
  • Status changed from Resolved to Closed

Implemented in r1736 with additional IN case '' (seen this for some menus in 2.5 installs)

Actions

Also available in: Atom PDF