Project

General

Profile

Actions

Bug #4542

closed

"Since 2 years ago" is wrong English, needs fixed

Added by beat almost 10 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
05 July 2014
Due date:
% Done:

100%

Estimated time:
2:00 h
Actions #1

Updated by krileon almost 10 years ago

Example of invalid usage as follows.

Member Since
2 years ago

Example of valid usage as follows.

Last Visit
2 years ago

The invalid usage should read as follows.

Member Since
2 years

So maybe a parameter to shut off the ago on a field by field basis. As is it's only language by language basis. To do that the cbFormatDate timeago usage should become a cbtimeago jquery plugin that can handle settings.. maybe data binding like cbtooltip? This way the strings can be changed on a field by field basis, etc.. so if you don't want "ago" it can be shut off, etc..

Actions #2

Updated by krileon almost 10 years ago

  • Target version set to CB 2.0.0

This could just be "Time Ago, with Ago" and "Time Ago, without Ago". Believe this actually used to be the case (or a separate param) in CB 1.x. Seams removed when moved to new Time Ago usage (jQuery driven).

Actions #3

Updated by krileon almost 10 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Implemented in MR !248

Actions #4

Updated by beat over 9 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF