Bug #5794
closed
CB version checker notifies nightly is out of date
Description
The nightly release, if greater than the stable release, should be marked as up to date. Currently if you install latest nightly then version checker will notify that your install is out of date and recommend the stable even if it's a nightly of the stable.
Updated by beat almost 9 years ago
- Status changed from Assigned to Feedback
Shouldn't I handle that server-side in the version checker responder ?
Updated by krileon almost 9 years ago
- Assignee changed from krileon to beat
Yes to both. The version checker shouldn't error if the installed is higher than the server responds with. If JP cache is out of date for example it would error, if we give them a custom nightly it would error, etc..
Updated by krileon almost 9 years ago
- Status changed from Feedback to Assigned
- % Done changed from 0 to 50
CBs side fixed in MR !1021
Version XML on JP still needs to be updated though. Not sure how this is going to work for free users though as it'd tell them to update to a nightly they can't access.
Updated by krileon almost 9 years ago
Admin module toggles the Joomla update site on if the version is out of date. Maybe it can also toggle it off when it isn't out of date to prevent it complaining that nightly is out of date?
Updated by krileon almost 9 years ago
This could also be fixed by a second CBLibRelease define for the release with $ueConfig['release'] holding the release in config. The release would be used strictly for display and the version for comparisons.
Updated by beat almost 9 years ago
I think that adding anything to $ueConfig is wrong as it's deprecated/obsolete.
The CBLIB define should stay imho the only define as is. But we could have a new `public function version( $format = null )` method in an existing class of CBLib that gives full version information. And use that one instead of CBLIB define wherever we need more than basic semver version.
Updated by krileon almost 9 years ago
For B/C CBLib and all 'version' usages must remain untouched. We need a new define to hold the release (this is updated with the parsing script Nick wrote). The new define is set to the config variable 'release'. Release is then used strictly for display purposes. This gives us 100% B/C while still allowing plugin management and configuration to show the version. If a function is added it strictly would be outputting what's already in config.
Updated by beat almost 9 years ago
- Target version changed from CB 2.0.14 to CB 2.0.15
Updated by beat over 8 years ago
- Target version changed from CB 2.0.15 to CB 2.1
Updated by krileon about 8 years ago
- Status changed from Assigned to Resolved
- % Done changed from 50 to 100
Nightly version checking implemented in MR !1170