Feature proposal #5882: Guzzle, PHP7, and minimum PHP 5.6 - CB - Joomlapolis forge

Actions

Copy link

Feature proposal #5882

closed

Guzzle, PHP7, and minimum PHP 5.6

Added by krileon about 8 years ago. Updated about 2 years ago.

Status:

Closed

Priority:

High

Assignee:

krileon

Target version:

CB 2.7.2

Start date:

24 March 2016

Due date:

% Done:

100%

Estimated time:

Description

We are currently using Guzzle 4, which is EOL and does not appear to be PHP7 compatible. Guzzle5 appears to be more compatible with PHP 7, but would push our minimum PHP requirement to 5.4.

https://www.joomlapolis.com/forum/255-developer-members-support/233259-error-after-upgrading-to-latest-joomlaphp7-and-cb-2014

https://github.com/guzzle/guzzle/tree/5.3

Related issues 1 (1 open — 0 closed)

Actions

Copy link

Updated by krileon about 8 years ago

Guzzle PHP7 Issue Tickets:
https://github.com/guzzle/guzzle/issues?utf8=%E2%9C%93&q=php7

Actions

Copy link

Updated by beat almost 8 years ago

Target version changed from CB 2.0.14 to CB 2.0.15

Actions

Copy link

Updated by krileon almost 8 years ago

Issues appear to be reported for 7.0.6. I'm unable to confirm on 7.0.4.

Actions

Copy link

Updated by beat almost 8 years ago

This is mainly due to the SSL method used by Guzzle, so host-dependent, not PHP 7-subversion dependant imho.

To reproduce you would need to remove the SSL library currenly used on your test-system.

PHP7 incompatibility in Guzzle seems to be due to stronger typing, so could be fixed easy.

Actions

Copy link

Updated by beat almost 8 years ago

I have analyzed the Guzzle class StreamAdapter, and it's clear that this array parameter can only be null when called from that line.

Thus I believe that bug is independant of PHP 7, but just because the user doesn't have the PHP OpenSSL library installed.

replying to forum.

Actions

Copy link

Updated by beat over 7 years ago

Target version changed from CB 2.0.15 to CB 2.1

Actions

Copy link

Updated by krileon over 7 years ago

Assignee set to krileon

Fatal error: Cannot use lexical variable $eventName as a parameter name in C:\wamp\www\develop\libraries\CBLib\GuzzleHttp\Event\Emitter.php on line 50

Appears to be another issue.

Actions

Copy link

Updated by krileon over 7 years ago

Priority changed from Normal to High

Actions

Copy link

Updated by krileon over 7 years ago

Target version changed from CB 2.1 to CB 2.2

Actions

Copy link

#10

Updated by krileon almost 7 years ago

Updated regarding this. We should move minimum PHP version to 5.6 then install latest Guzzle available (currently Guzzle 6). Additionally it seams it maybe possible that we're having conflicts with other Guzzle libraries since we have not changed the namespace to be CB specific. For instance Guzzle 6 is available from a 3rd party extension, but ours is Guzzle 4. When we call Guzzle the autoloader of that extension, if loaded, could result in Guzzle 6 loading causing an incompatibility. This won't really be a big deal if we stay up to date.

Actions

Copy link

#11