Project

General

Profile

Feature proposal #6850

Remove htmlspecialchars_decode in content bot

Added by krileon almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
High
Assignee:
Target version:
Start date:
09 November 2017
Due date:
% Done:

100%

Estimated time:

Description

htmlspecialchars_decode is being applied to the entire article text which in some cases can break existing markup, but this is needed to allow substitution shortcode to match since so many extensions and Joomla mess with the markup (WYSIWYG editors are a huge culprit here). See if this can be removed or done in a way that won't break the original markup.

https://www.joomlapolis.com/forum/147-potential-bug/237747-htmlspecialchars-decode-in-cbcontentbot-php#298859

History

#1 Updated by krileon over 1 year ago

Simple fix for this is to change the " matching in REGEXP to (?:"|") allowing it to match the encoded version as well. The reason this issue happens is if you put a substitution inside of a WYSIWYG link URL parameter it'll encode the " (which is correct), but we still want the substitution to work.

#2 Updated by krileon over 1 year ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Fixed in MR !1304

Individual content bots need to also be fixed and any other custom substitution parsing needs to handle encoded quotes.

#3 Updated by beat over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF