Project

General

Profile

Actions
Copy link

Bug #6897

closed

Test and fix PHP 7.2 compatibility issues

Added by krileon over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
krileon
Target version:
CB 2.1.4
Start date:
30 November 2017
Due date:
% Done:

100%

Estimated time:

Description

Appears to be PHP 7.2 compatibility issues that need to be fixed before the PHP 7.2 update is pushed to hosting providers. Below reported issues thus far.

\libraries\CBLib\CB\Legacy\cbPluginHandler.php line 223
if ( count( $ids ) == 0 ) {

$ids is not always an array (it can be null) so calling count on it now throws a notice in PHP 7.2.

Actions
Copy link
 #2

Updated by krileon about 6 years ago

Implement a notice (maybe in configuration? panel?) if PHP version is less than 5.6 as that will be the new minimum in CB 2.2.

Actions
Copy link
 #3

Updated by krileon about 6 years ago

  • % Done changed from 0 to 90

Fixed in MR !1303

Actions
Copy link
 #4

Updated by krileon about 6 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 90 to 100
Actions
Copy link
 #5

Updated by beat about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF