Project

General

Profile

Actions

Bug #7432

closed

Language finder not working unless backend language is default

Added by krileon almost 6 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
22 January 2019
Due date:
% Done:

100%

Estimated time:

Description

If backend language is anything other than English (default) then the language finder fails to find any strings. This shouldn't matter though with the reset loading behavior changes in the finder.

https://www.joomlapolis.com/forum/153-professional-member-support/240412-language-overrides#310062

Actions #1

Updated by krileon almost 6 years ago

  • Priority changed from Normal to Low

Unable to confirm. Set backend to Japanese. Then searched nl-BE CB language plugin fine.

Actions #2

Updated by krileon almost 6 years ago

  • Priority changed from Low to Normal

Ok, was able to confirm this by setting backend Joomla language to nl-BE then attempting to search the CB language plugin nl-BE. Result is no results.

Actions #3

Updated by krileon almost 6 years ago

It's purely due to case sensitivity. It's being converted to nl-be instead of nl-BE.

Actions #4

Updated by krileon almost 6 years ago

The language finder XML needs to just pass plugin element instead of plugin folder to the finder. This doesn't work for CBSubs language plugins though as they have a element of cbsubs-nl-NL but a folder of cbpaidsubscriptions-nl-nl.

Actions #5

Updated by krileon almost 6 years ago

CBTxt it self needs improved as there's no reason it to be case sensitive for language tag.

Actions #6

Updated by krileon almost 6 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Fixed in MR !1454

The fix is to normalize language tag in CBTxt to lowercase.

Actions #7

Updated by beat almost 6 years ago

  • Status changed from Resolved to Closed
Actions #8

Updated by krileon over 4 years ago

  • Status changed from Closed to Feedback
  • Assignee deleted (krileon)
  • Target version changed from CB 2.4.1 to CB 2.4.6
  • % Done changed from 100 to 0

Re-opening as this has yet to be merged. This still needs fixed. The issue is caused by language tags not being normalized which cases case sensitive loading issues.

Actions #9

Updated by beat over 4 years ago

  • Target version changed from CB 2.4.6 to CB 2.4.7
Actions #10

Updated by beat about 4 years ago

  • Target version changed from CB 2.4.7 to CB 2.5.0
Actions #11

Updated by krileon about 4 years ago

  • Status changed from Feedback to Resolved
  • Assignee set to krileon
  • % Done changed from 0 to 100

Fixed in MR !1602

Instead of altering language parsing behavior simply don't use it for language finder. Instead just work with the array of strings directly which avoids language loading conflicts entirely.

Actions #12

Updated by beat almost 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF