Project

General

Profile

Actions

Bug #7671

closed

First save of language overrides does not redisplay the new overrides

Added by krileon over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
07 August 2019
Due date:
% Done:

100%

Estimated time:

Description

The overrides are saved, but because the override file was included before the save occurred due to language loading behavior when it's included again later it's included from memory so it does not have the new language override strings that were just added to it. Refreshing the page displays the changes correctly and this is entirely a display bug (storage works fine).

Actions #1

Updated by krileon over 5 years ago

This is due to the overrides taking too long to write to file. The redirect happens before the file finishes being written to, which doesn't make any sense since file put contents is a blocking operation. Adding a sleep statement fixes this, but that shouldn't be necessary.

Actions #2

Updated by krileon over 5 years ago

Seams to be an issue entirely isolated to Windows based servers. Not seeing issues on Linux based installs (e.g. demo site).

Actions #3

Updated by krileon over 5 years ago

It's caused by OPcache. Once disabled the issue resolves. The include is being cache and refuses to refresh until the cache has left memory. Calling opcache_invalidate before the include will resolve this.

Actions #4

Updated by krileon over 5 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Fixed in MR !1487

Actions #5

Updated by beat almost 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF