Project

General

Profile

Actions

Bug #7887

open

IF substitutions don't reliably allow quotes

Added by krileon about 4 years ago. Updated 5 months ago.

Status:
Assigned
Priority:
Normal
Assignee:
Target version:
Start date:
19 March 2020
Due date:
% Done:

0%

Estimated time:

Description

Using a quote inside of an IF substitution value doesn't reliably work. Examples as follows.

[cb:if user_id="4"2"]ME[/cb:if]

With the old REGEXP this worked. With new it does not. With new the below should work.

[cb:if user_id="4\"2"]ME[/cb:if]

This however also does not work. See if a fallback can be added to use the previous REGEXP behavior if we fail with the new one. This appears to only be an issue if using quotes inside a substitution which is likely unused or uncommon.

Actions #1

Updated by krileon about 4 years ago

[cb:if user_id="4"2"]ME[/cb:if] previously worked by chance since the old REGEXP basically allowed whatever you wanted up until the first instance of a ]. It would then produce an invalid IF condition and fail. We should not accept invalid syntax. This means [cb:if user_id="4\"2"]ME[/cb:if] just needs to be fixed as escaping it should be acceptable. [cb:if user_id="4"2"]ME[/cb:if] encoded case should also be supported.

Actions #2

Updated by beat almost 4 years ago

  • Target version changed from CB 2.4.5 to CB 2.4.6
Actions #3

Updated by beat over 3 years ago

  • Target version changed from CB 2.4.6 to CB 2.4.7
Actions #4

Updated by beat over 3 years ago

  • Target version changed from CB 2.4.7 to CB 2.5.0
Actions #5

Updated by beat about 3 years ago

  • Target version changed from CB 2.5.0 to CB 2.6
Actions #6

Updated by beat almost 3 years ago

  • Target version changed from CB 2.6 to CB 2.6.1
Actions #7

Updated by beat over 2 years ago

  • Target version changed from CB 2.6.1 to CB 2.7
Actions #8

Updated by beat about 2 years ago

  • Target version changed from CB 2.7 to CB 2.7.2
Actions #9

Updated by beat about 2 years ago

  • Target version changed from CB 2.7.2 to CB 2.7.3
Actions #10

Updated by beat almost 2 years ago

  • Target version changed from CB 2.7.3 to CB 2.7.4
Actions #11

Updated by krileon over 1 year ago

  • Target version changed from CB 2.7.4 to CB 2.8
Actions #12

Updated by beat about 1 year ago

  • Target version changed from CB 2.8 to CB 2.8.1
Actions #13

Updated by beat 8 months ago

  • Target version changed from CB 2.8.1 to CB 2.8.2
Actions #14

Updated by beat 7 months ago

  • Target version changed from CB 2.8.2 to CB 2.9.0
Actions #15

Updated by beat 5 months ago

  • Target version changed from CB 2.9.0 to CB 2.9.2
Actions

Also available in: Atom PDF