Project

General

Profile

Actions

Feature proposal #7944

closed

Implement plans page renewal button specific language string

Added by krileon over 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
17 April 2020
Due date:
% Done:

100%

Estimated time:

Description

Currently the renewal button on the plans page is an implode of several generic parts (Renew, price, for, and duration). This needs to have a more specific language string in addition to this behavior so it can be overridden specifically (e.g. change it to just say Renew Now).

https://www.joomlapolis.com/forum/153-professional-member-support/242344-hide-price-from-buttons#317852


Related issues 1 (0 open1 closed)

Related to CB Paid Subscriptions - Feature proposal #7723: Implement plans page upgrade button specific language stringClosedkrileon23 September 2019

Actions
Actions #1

Updated by krileon over 2 years ago

Actions #2

Updated by krileon over 2 years ago

This either needs to be improved in cbpaidSomething::checkRenewalUpgrade before button_text is set in _allowedActions or when _allowedActions is processed in cbpaidControllerUI::_drawActionButton (would apply to all action buttons). Best approach is probably checkRenewalUpgrade so it can be separated into its parts. Example as follows.

CBTxt::T( 'RENEW_PLAN_BUTTON', '[button_text][separator][period_price]', ... )

Another option is to take the same approach as the upgrade button language string with the below.

CBTxt::T( 'RENEW_PLAN_BUTTON_OVERRIDE_TEXT', '' )

If it has a value use it otherwise don't, but then you lose the option to substitute in the period price if desired.

Actions #3

Updated by krileon over 2 years ago

Looks like each can be given a generic language key with a also specific language key as follows.

CBPTXT::Th( 'PLAN_RENEW_BUTTON RENEW_PLAN_BUTTON', '[button_text][separator][period_price]', ... )
CBPTXT::Th( 'PLAN_RENEW_BUTTON REACTIVATE_PLAN_BUTTON', '[button_text][separator][period_price]', ... )
CBPTXT::Th( 'PLAN_RENEW_BUTTON RESUBSCRIBE_PLAN_BUTTON', '[button_text][separator][period_price]', ... )

All 3 are renew actions and all 3 contain the same 3 parts so this allows mass overriding to output just [button_text] if desired or altering on a specific level.

Actions #4

Updated by krileon over 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Implemented in MR !186

Actions #5

Updated by beat over 2 years ago

  • Status changed from Resolved to Assigned
  • % Done changed from 100 to 50

Minor implementation change welcome (see MR !186)

Actions #6

Updated by beat over 2 years ago

  • Target version changed from 4.4.0 to 4.5.0
Actions #7

Updated by beat almost 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 50 to 100

Implemented by Kyle in MR !186 (merged)

Actions #8

Updated by beat over 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF