Feature proposal #7944
closed
This either needs to be improved in cbpaidSomething::checkRenewalUpgrade before button_text is set in _allowedActions or when _allowedActions is processed in cbpaidControllerUI::_drawActionButton (would apply to all action buttons). Best approach is probably checkRenewalUpgrade so it can be separated into its parts. Example as follows.
CBTxt::T( 'RENEW_PLAN_BUTTON', '[button_text][separator][period_price]', ... )
Another option is to take the same approach as the upgrade button language string with the below.
CBTxt::T( 'RENEW_PLAN_BUTTON_OVERRIDE_TEXT', '' )
If it has a value use it otherwise don't, but then you lose the option to substitute in the period price if desired.
Looks like each can be given a generic language key with a also specific language key as follows.
CBPTXT::Th( 'PLAN_RENEW_BUTTON RENEW_PLAN_BUTTON', '[button_text][separator][period_price]', ... )
CBPTXT::Th( 'PLAN_RENEW_BUTTON REACTIVATE_PLAN_BUTTON', '[button_text][separator][period_price]', ... )
CBPTXT::Th( 'PLAN_RENEW_BUTTON RESUBSCRIBE_PLAN_BUTTON', '[button_text][separator][period_price]', ... )
All 3 are renew actions and all 3 contain the same 3 parts so this allows mass overriding to output just [button_text] if desired or altering on a specific level.
- Status changed from Assigned to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Assigned
- % Done changed from 100 to 50
Minor implementation change welcome (see MR !186)
- Target version changed from 4.4.0 to 4.5.0
- Status changed from Assigned to Resolved
- % Done changed from 50 to 100
Implemented by Kyle in MR !186 (merged)
- Status changed from Resolved to Closed
Also available in: Atom
PDF