Project

General

Profile

Actions

Feature proposal #8973

open

Implement support for Joomla proxy settings for Guzzle

Added by krileon 2 months ago. Updated about 2 months ago.

Status:
Assigned
Priority:
Low
Assignee:
Target version:
Start date:
14 June 2022
Due date:
% Done:

0%

Estimated time:

Description

Guzzle isn't able to connect through the proxy when making requests resulting in them failing. This needs to be set per-client so is an implementation problem as all Guzzle usages would need to be updated, which if we're to do that we might as well move to Symfony HTTP Client instead (planned for CB 3.x). Needs further review as only way to globally do this is middleware, which again requires changes to every Guzzle call.

https://docs.guzzlephp.org/en/stable/handlers-and-middleware.html?highlight=default#middleware

https://www.joomlapolis.com/forum/153-professional-member-support/243757-internet-access-what-to-whitelist#329695

Actions #1

Updated by krileon 2 months ago

Guzzle 7 will utilize the environment variable HTTP_PROXY, HTTPS_PROXY, and NO_PROXY. So that's going to be our best option for doing this. We can globally set it there. We'll need to do this early in the CBFramework initialization. This needs to be set into $_SERVER.

Actions #2

Updated by krileon 2 months ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Implemented in MR !1807

Actions #3

Updated by krileon about 2 months ago

  • Status changed from Resolved to Assigned
  • % Done changed from 100 to 0

Needs further thought. Changing globals isn't typically a good idea and if needed can be done via CB Auto Actions to set those globals. This should be done in CB via Guzzle middleware. Ideally a DI for Application::Request() would be best.

Actions #4

Updated by beat about 2 months ago

  • Target version changed from CB 2.7.3 to CB 2.7.4
Actions

Also available in: Atom PDF