Project

General

Profile

Actions
Copy link

Bug #1279

closed

Lists advanced search: Search any of a single-drop-down field but selecting empty line in multi-select field gives invalid SQL query

Added by krileon about 15 years ago. Updated almost 15 years ago.

Status:
Closed
Priority:
Low
Assignee:
beat
Target version:
CB 1.2.2
Start date:
14 September 2009
Due date:
% Done:

100%

Estimated time:
3:00 h

Description

http://www.joomlapolis.com/component/option,com_joomlaboard/Itemid,38/func,view/id,110842/catid,100/

Files

Download all files
1279_unified.patch (737 Bytes) 1279_unified.patch Unified Patch krileon, 28 January 2010 00:32
1279-plugin.class.php.patch (648 Bytes) 1279-plugin.class.php.patch beat, 28 January 2010 01:09
Actions
Copy link
 #1

Updated by beat about 15 years ago

  • Target version set to CB 1.2.2
Actions
Copy link
 #2

Updated by beat almost 15 years ago

  • Estimated time set to 3:00 h
Actions
Copy link
 #3

Updated by krileon almost 15 years ago

  • File 1279.patch added
  • Status changed from New to Assigned
  • Assignee changed from krileon to beat
  • % Done changed from 0 to 80

The issue was with the building of the query checking for != '' instead of !== null, as blanks are permitted. This caused it to place an empty AND inside of the query. Function reduceSqlFormula in plugin.class.php.

Actions
Copy link
 #4

Updated by krileon almost 15 years ago

  • File deleted (1279.patch)
Actions
Copy link
 #5

Updated by krileon almost 15 years ago

  • File deleted (1279.patch)
Actions
Copy link
 #7

Updated by beat almost 15 years ago

  • Subject changed from Multi select drop down error to Lists advanced search: Search any of a single-drop-down field but selecting empty line in multi-select field gives invalid SQL query
  • Status changed from Assigned to Closed
  • % Done changed from 80 to 100

Not agreeing with the patch, as it gives wrong results, allowing selection of the empty row generating '' and wrong results.

Enclosed another patch, which gives expected behavior.

Committed in r848 .
(after 1.2.2 beta 1)

Actions
Copy link

Also available in: Atom PDF