Project

General

Profile

Actions

Bug #1908

closed

Dropdown fields containing >< are not saved

Added by RCheesley over 14 years ago. Updated about 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
01 August 2010
Due date:
% Done:

100%

Estimated time:
1:30 h

Description

Created a dropdown list with >1yr <1 yr and when the field was selected, hitting submit kept saying it was not selected (it was a mandatory field). Assume the code isn't being sanitised properly.


Files

1908.patch (823 Bytes) 1908.patch krileon, 18 August 2010 18:27
Actions #1

Updated by krileon over 14 years ago

  • % Done changed from 0 to 20

Confirmed, values are NOT escape before they are saved to database. Will investigate further as to why, they should be htmlspecialed before storing.

Actions #2

Updated by krileon over 14 years ago

Reviewing source it is being htmlspecialed on frontend so no backend htmlspecial needed.

Actions #3

Updated by krileon over 14 years ago

Applies to <TEXT, but >TEXT works fine.

Actions #4

Updated by krileon over 14 years ago

cbGetParam was missing _MOS_ALLOWRAW preventing raw input from being obtained (further sensitization is done below to ensure it's safe)

Actions #5

Updated by krileon about 14 years ago

  • Status changed from New to Resolved
Actions #6

Updated by krileon about 14 years ago

  • Target version set to CB 1.3
Actions #7

Updated by beat about 14 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 80 to 100
  • Estimated time set to 1:30 h

Fixed in r1248 as suggested by patch, but also added strict to the in_array checks for valid entries, to avoid any lowering of security by the patch.

Thank you, Kyle.

Actions #8

Updated by beat about 14 years ago

Fixed regression in r1268:

Notice: Use of undefined constant strict - assumed 'strict' in D:\xampp\htdocs\cb\j15\components\com_comprofiler\plugin\user\plug_cbcore\cb.core.php on line 723
[19.11.10 18:27:17] Kyle: as for activity plugin, it already works? what's broken about it?

Actions

Also available in: Atom PDF