Project

General

Profile

Actions

Bug #2304

closed

Lastupdate 1 hour bug in J! 1.5 and CB 1.3.1 / CB 1.4.0

Added by Lintzy about 13 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
07 February 2011
Due date:
% Done:

100%

Estimated time:
1:30 h

Description

This bug concerns to Joomla 1.5 only (not Joomla 1.6) but appears in both versions: CB 1.3.1 and CB 1.4. The lastvisited time is proper.

How to produce? Change Joomla Server Time to Berlin, change Userprofil timesetting to Berlin, then go to frontend and actualisize your profile and look to lastupdated field: it shows one hour in future.


Files

2304.patch (646 Bytes) 2304.patch krileon, 10 February 2011 18:10
Actions #1

Updated by krileon about 13 years ago

  • Status changed from New to Feedback
  • Assignee set to Lintzy

Could not duplicate on Windows server with the above (+01:00) offset set in Joomla global and user settings. Am consistently given "Now" as last update time. Are you able to provide more details about your environment? What time is your server set to? Are you able to place var_dump( date( 'Y-m-d H:i:s', time()) ); anywhere to review its output to see if your servers time is set correctly?

Actions #2

Updated by Lintzy about 13 years ago

You can test it and reproduce it on http://languages.cbdemosites.com - ask Nant for more informations and backend access, if you don't have now.

All settings are done, to reproduce the bug. Change your user timezone also to Berlin (+1hour) (look at joomla server time, it's the same). Don't know in the moment, if the bug appears too with global default setting in user account.

Actions #3

Updated by beat about 13 years ago

  • Status changed from Feedback to Assigned
  • Assignee changed from Lintzy to krileon
  • Estimated time set to 1:30 h
Actions #4

Updated by krileon about 13 years ago

  • Assignee changed from krileon to nant

Need version numbers for http://languages.cbdemosites.com, likely significantly out of date. I can not duplicate this issue with latest 1.4 SVN and its various fix patches. Possible issue already resolved or related to linux based installs only (am on windows localhost).

Actions #5

Updated by nant about 13 years ago

  • Assignee changed from nant to krileon

Kyle the website has latest CB 1.4 RC installed - I have created a superadmin account for you so you can check.

Actions #6

Updated by krileon about 13 years ago

  • File 2304.patch 2304.patch added
  • Status changed from Assigned to Resolved
  • Assignee changed from krileon to beat
  • % Done changed from 0 to 100

Joomla does setLocale which alters how date() returns formatted dates (with offset). The offset seams to only apply if the user is logged in as well, which is why register date and last visit date are not affected.

The proposed patch will remove the offset (if any of course) so the date is stored properly without offset within the database. The field then adds the offset (as it should, database datetimes should be without offset) and displays it correctly (without being 1hr in the future).

Actions #7

Updated by Lintzy about 13 years ago

Patch tested. 1h bug is fixed with it :).

Actions #8

Updated by beat about 13 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from beat to nant
  • % Done changed from 100 to 90

Fixed this bug differently than suggested.

Although suggestion to use UTC time for the datetime fields is good for CB 2.0, in CB 1.x we need to keep the broken DATETIME usage of Joomla, which uses local server time based on the joomla offset setting.

Also the lastupdatetime was broken at all writes, e.g. at avatar approvals, and so on, so needed a few other fixes.

r1439 and r1440 fixes this, but will need tests, after Nick updates the test site with latest build.

Assigning to Nick for updating the test site: Nick then assign to Lintzy for final test.

Actions #9

Updated by beat about 13 years ago

  • Assignee changed from nant to Lintzy

Lintzy,
(Or someone else)
Can you please confirm that the bug is also fixed with the 1.4 RC2 testteam package Nick sent you?

Thanks,
Beat

Actions #10

Updated by beat about 13 years ago

  • Assignee changed from Lintzy to nant

Waiting on test confirmation on this last open bug in CB itself.

Actions #11

Updated by nant about 13 years ago

Installed latest CB 1.4 RC2 on language site and could not reproduce using the instructions given. So I guess its fixed.

Actions #12

Updated by beat about 13 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 90 to 100

Thanks. Closing.

Actions

Also available in: Atom PDF