Project

General

Profile

Actions

Bug #2307

closed

PMS UddeIM integration : needs modification for %livesite%

Added by nant almost 14 years ago. Updated almost 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
09 February 2011
Due date:
% Done:

100%

Estimated time:
2:00 h

Description

[12:30:11 πμ] Nicholas G. Antimisiaris: https://www.joomlapolis.com/forum/154-advanced-members-support/153546-problem-with-welcome-plugin-livesite-in-email
[12:30:17 πμ] Nicholas G. Antimisiaris: any suggestions on this one?
[12:30:27 πμ] Nicholas G. Antimisiaris: we are also getting this on JP
[10:21:29 πμ] Stephan Slabihoud: yes, the uddeIM PMS plugin has an parameter livesite which is not known in the CB plugin.
[10:21:59 πμ] Stephan Slabihoud: maybe the autowelcome plugin uses this parameter
[10:22:23 πμ] Nicholas G. Antimisiaris: what is the api call?
[10:23:17 πμ] Stephan Slabihoud: api call?
[10:23:56 πμ] Stephan Slabihoud: as far as I can see, the problem is that the uddeIM PMS plugin sometimes shows "rn" instead of cr's lf's
[10:24:22 πμ] Stephan Slabihoud: last post in http://www.joomlapolis.com/forum/120-autowelcome/134131-new-line-in-message-is-not-working?limit=6&start=12
[10:25:12 πμ] Nicholas G. Antimisiaris: that is one issue with your plugin - the core cb integration works ok
we use the core on JP, but if someone has requested an email notification with the pms contents in the email, then the email contains the livesite
[10:26:05 πμ] Stephan Slabihoud: check _pmsUddeDispatchEMN() in pms.uddeim.php
[10:26:13 πμ] Stephan Slabihoud: there is the complete code for all placeholders
[10:27:32 πμ] Stephan Slabihoud: I am not quite sure but is I think it is already fixed in the trunk (the rn problem), will check
[10:28:52 πμ] Stephan Slabihoud: yes, I did a change there, maybe the guy could use the plugin from 2.3rc (only the plugin, he should not upgrade)
[10:30:11 πμ] Nicholas G. Antimisiaris: well, we need to fix the livesite issue in our plugin
[10:30:19 πμ] Nicholas G. Antimisiaris: trying to figure out how
[10:30:38 πμ] Stephan Slabihoud: very easy
[10:30:40 πμ] Nicholas G. Antimisiaris: still don;t understand why this is a plugin issue
[10:30:55 πμ] Nicholas G. Antimisiaris: since the setting to send email notifications is a uddeIM feature
[10:31:48 πμ] Stephan Slabihoud: Yes, but notifications are send by the plugin, there is currently no API call for that
[10:32:16 πμ] Stephan Slabihoud: I could add this to the uddeIM API but this requires rewriting the CB PMS plugin in major parts.
[10:32:35 πμ] Stephan Slabihoud: Thats the reason I started an own plugin
[10:32:39 πμ] Stephan Slabihoud: here is the code you have to add
[10:32:40 πμ] Stephan Slabihoud: if ($emn_option==1) {
$var_body = _UDDEIM_EMN_FORGETMENOT;
$var_body = str_replace("%livesite%", $this->mosConfig_live_site, $var_body);
$var_body = str_replace("%you%", $var_toname, $var_body);
$var_body = str_replace("%site%", $this->mosConfig_sitename, $var_body);
$var_body = str_replace("%msglink%", $msglink, $var_body);
} else {
if ($this->config->emailwithmessage==1) {
$var_body = _UDDEIM_EMN_BODY_WITHMESSAGE;
$var_body = str_replace("%livesite%", $this->mosConfig_live_site, $var_body);
$var_body = str_replace("%you%", $var_toname, $var_body);
$var_body = str_replace("%site%", $this->mosConfig_sitename, $var_body);
$var_body = str_replace("%msglink%", $msglink, $var_body);
$var_body = str_replace("%user%", $var_fromname, $var_body);
$var_body = str_replace("%pmessage%", $var_message, $var_body);
} else {
$var_body = _UDDEIM_EMN_BODY_NOMESSAGE;
$var_body = str_replace("%livesite%", $this->mosConfig_live_site, $var_body);
$var_body = str_replace("%you%", $var_toname, $var_body);
$var_body = str_replace("%site%", $this->mosConfig_sitename, $var_body);
$var_body = str_replace("%msglink%", $msglink, $var_body);
$var_body = str_replace("%user%", $var_fromname, $var_body);
}
}

$subject = _UDDEIM_EMN_SUBJECT;
$subject = str_replace("%livesite%", $this->mosConfig_live_site, $subject);
$subject = str_replace("%site%", $this->mosConfig_sitename, $subject);
$subject = str_replace("%you%", $var_toname, $subject);
$subject = str_replace("%user%", $var_fromname, $subject);
[10:33:06 πμ] Stephan Slabihoud: Replace the old code in PMS plugin with that one
[10:33:41 πμ] Nicholas G. Antimisiaris: will open a tracker item for this - lets see if we can fix in next CB 1.4
[10:35:55 πμ] Nicholas G. Antimisiaris: $emn_option
[10:35:59 πμ] Nicholas G. Antimisiaris: where is this defined?

Files

2307.patch (5.56 KB) 2307.patch krileon, 09 February 2011 15:48
Actions #1

Updated by nant almost 14 years ago

[10:39:36 πμ] Stephan Slabihoud: function _pmsUddeDispatchEMN($var_msgid, $var_fromid, $var_toid, $var_message, $emn_option, $udde_sysm) {}
[10:39:49 πμ] Stephan Slabihoud: it is also called in you CB plugin, I think
[10:40:03 πμ] Stephan Slabihoud: in _pmsUddeNotify()

Actions #2

Updated by nant almost 14 years ago

in function _sendPMSuddeimMSG($udde_toid,$udde_fromid,$to,$from,$sub,$msg) {}
[10:40:37 πμ] Stephan Slabihoud: in sendUserPMS()

Actions #3

Updated by beat almost 14 years ago

  • Estimated time set to 2:00 h
Actions #4

Updated by krileon almost 14 years ago

  • File 2307.patch 2307.patch added
  • Status changed from Assigned to Resolved
  • Assignee changed from krileon to beat
  • % Done changed from 0 to 100
Actions #5

Updated by beat almost 14 years ago

  • Subject changed from uddeIM PMS integration needs modification for %livesite% to PMS UddeIM integration : needs modification for %livesite%
  • Status changed from Resolved to Closed

Fixed as suggested (with sefing added for the message link) in r1431.

Thanks Stephan, Kyle and Nick

Actions

Also available in: Atom PDF