Project

General

Profile

Actions

Bug #2337

closed

Advanced filter not working with last online field

Added by nant about 13 years ago. Updated almost 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
19 February 2011
Due date:
% Done:

100%

Estimated time:
3:00 h

Description

As described here:

http://www.joomlapolis.com/forum/147-potential-bug/154725-advanced-search-for-never-logged-in-is-not-working

it looks like the filtering does not work on the Last Online field.


Files

2337.patch (3.92 KB) 2337.patch krileon, 27 April 2011 21:57

Related issues 1 (0 open1 closed)

Related to CB - Bug #2348: Selecting min or max date of a date range field results in all users displayedClosedbeat23 February 2011

Actions
Actions #1

Updated by krileon almost 13 years ago

  • Assignee set to krileon

Confirmed, "is not" returns the same results as "is".

Actions #2

Updated by krileon almost 13 years ago

Reviewing further if the "Between" date is specified and not the "and" date then it'll find everyone with a date GREATER than specified. If the "and" date is specified and NOT the "Between" date then it'll find everyone with a date LESS than specified. This can be reversed with an IF statement to change the search operator based off search mode, which seams best approach (making "Between" the less than and "and" the greater than).

Actions #3

Updated by krileon almost 13 years ago

  • Status changed from New to Feedback
  • Assignee changed from krileon to beat

Seams cbSqlQueryPart needs to be expanded to handle ranges. Example query below with current usage of isnot.

WHERE ((u.`lastvisitDate` >= '2011-01-26')
AND (u.`lastvisitDate` <= '2011-01-28'))

If expanded to handle ranges would be as follows.

WHERE ((u.`lastvisitDate` NOT BETWEEN '2011-01-26' AND '2011-01-28'))

Actions #4

Updated by krileon almost 13 years ago

  • Status changed from Feedback to Assigned
  • Assignee changed from beat to krileon

Appears can be resolved using OR instead of AND in those scenarios, which API certainly supports.

Actions #5

Updated by krileon almost 13 years ago

  • File 2337.patch 2337.patch added
  • Status changed from Assigned to Resolved
  • Assignee changed from krileon to beat
  • % Done changed from 0 to 100

Completely rewrote the code responsible for search query criteria. Using addChildren method when necessary was able to provide an AND/OR scenario.

Actions #6

Updated by beat almost 13 years ago

  • Target version set to CB 1.7
Actions #7

Updated by beat almost 13 years ago

  • Estimated time set to 3:00 h
Actions #8

Updated by beat almost 13 years ago

  • Status changed from Resolved to Closed

Fixed in r1487 by implementing the proposed patch. Thank you Kyle.

Actions

Also available in: Atom PDF