Project

General

Profile

Actions

Bug #4595

closed

Undefined index when uploading canvas image

Added by nant over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
07 August 2014
Due date:
% Done:

100%

Estimated time:
1:00 h

Description

Steps to reproduce:

With Debug on upload a jpg canvas image to see error:

Notice: Undefined index: conversiontype in /Users/nick/Documents/JOOMLAPOLIS/DEV/SITES/CB20PREVIEW/components/com_comprofiler/plugin/user/plug_cbcore/cb.core.php on line 2839

Actions #1

Updated by beat over 9 years ago

  • % Done changed from 0 to 50
  • Estimated time set to 1:00 h

MR !323 is a proposed easy fix for this.

However I'm not sure why you got this as default config should be set on fresh installs, and on existing installs, that setting should be there imho.

So leaving this as only half resolved and leaving assigned to Kyle for closing comment.

Actions #2

Updated by krileon over 9 years ago

  • Status changed from Assigned to Feedback
  • Assignee changed from krileon to beat

Looks like config was never saved in any case. Config basically has the same limits of CBSubs except output the benefit of using getter/setter so you end up with errors like that if config is never saved. It should be saved at least once or the usages of the config global should do isset checks. One option is to load the config XML during install and save it to ensure defaults are stored, but unsure if we'd want to go that approach as by 2.1 we should be using proper config object with getter/setter.

Actions #3

Updated by krileon over 9 years ago

  • Status changed from Feedback to Assigned
  • Assignee changed from beat to krileon

This can be avoided by having the installer check for missing keys using the defaults from XML. Implement this when implementing the other plugin migrations to the installer.

Actions #4

Updated by krileon over 9 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 50 to 100

Fixed in MR !336

Actions #5

Updated by beat over 9 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF