Project

General

Profile

Actions

Bug #4653

closed

Banned and Enabled toggles on User Manager has a pending state

Added by nant over 10 years ago. Updated about 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
01 September 2014
Due date:
% Done:

100%

Estimated time:

Description

I think this is wrong.

On CB User Manager I can toggle the Banned column to a pending state that does not really make sense.

Same is true for Enabled column.

Also we need to be consistent in wording - for example the Banned state does not appear in edit mode - should it?
Also the Enabled state seems to map to the Block user parameter.

Actions #1

Updated by beat over 10 years ago

1. Enabled:

Enabled is "not Blocked", always bee: That's Joomla terminology: "Block this user" in User edit, and "Enabled" in User Management views. Maybe not 100% consistent, but I like "Enabled" better.

"Enabled" is a yes/no. I don't think there is a pending state.

2. Banned:

Putting a user into "Pending" state without going through the workflow doesn't make sense imho ?

Actions #2

Updated by nant over 10 years ago

beat wrote:

1. Enabled:

Enabled is "not Blocked", always bee: That's Joomla terminology: "Block this user" in User edit, and "Enabled" in User Management views. Maybe not 100% consistent, but I like "Enabled" better.

"Enabled" is a yes/no. I don't think there is a pending state.

2. Banned:

Putting a user into "Pending" state without going through the workflow doesn't make sense imho ?

If I disable the user (with a toggle click on the Enabled column), the Joomla user Block User field is checked.

Believe it or not I was able to put the Enabled column to a clock pending state - of course now I cannot replicate ;-(

But the banned column still goes through a pending state and so does the Confirmed column.

Actions #3

Updated by beat over 10 years ago

Something strang there. What was the exact workflow for state-toggles for those in CB 1.9.1 ? i remember having gone through these workflows in CB 1.x and it wasn't trivial.

Actions #4

Updated by nant over 10 years ago

beat wrote:

Something strang there. What was the exact workflow for state-toggles for those in CB 1.9.1 ? i remember having gone through these workflows in CB 1.x and it wasn't trivial.

I remember that in CB 191 we did not have a banned state on CB User Manager table and we did not allow the Confirmed column to toggle.

We only allowed the Approved column to toggle.

Actions #5

Updated by beat over 10 years ago

Correct, and Approved column could not go back to pending state there. But if it was in pending state it was going to approved one by clicking it.

Actions #6

Updated by krileon over 10 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Fixed in MR !397

Actions #7

Updated by beat about 10 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF