Project

General

Profile

Actions
Copy link

Bug #5216

closed

ID translation not being picked up

Bug #5216: ID translation not being picked up

Added by nant over 11 years ago. Updated about 1 month ago.

Status:
Rejected
Priority:
Normal
Assignee:
beat
Target version:
-
Start date:
03 April 2015
Due date:
% Done:

100%

Estimated time:

Description

The admin_language.php file has

'ID_b718ad' => 'ID',

but this is not being picked up in the CB Tab, Plugin, Field and List pages.

See image

Files

2015-04-03_18-04-47.jpg (12.6 KB) 2015-04-03_18-04-47.jpg nant, 03 April 2015 17:05
2015-04-03_18-04-47.jpg

Updated by krileon over 11 years ago Actions
Copy link
 #1

Works: 'ID' => '!ID',
Doesn't Work: 'ID_b718ad' => '!ID',

This appears to be a bug with the key. Either the key is incorrect (wrong MD5?) or the MD5 generated by CBTxt doesn't match that generated by the lang parser.

Updated by krileon over 11 years ago Actions
Copy link
 #2

generateKeyFromString appears to be skipping this string entirely.

Updated by krileon over 11 years ago Actions
Copy link
 #3

  • Assignee changed from krileon to beat

It's due to if ( $key === '' || $key = = $languageKeys ) { specifically the $key = = $languageKeys test. What's happening is ID = = ID is causing the IF to pass and returning null. So it's not generating an MD5 key.

Updated by beat over 11 years ago Actions
Copy link
 #4

  • Assignee changed from beat to krileon

A language key should normally not be identical to the English string. Maybe we should use language key "LIST_ITEM_ID" here ?

Updated by krileon over 11 years ago Actions
Copy link
 #5

  • Status changed from Assigned to Feedback
  • Assignee changed from krileon to beat

I guess so, but we've multiple plugins already using ID without a key specified. Wouldn't it make sense for CB to just always generate the key?

Updated by beat over 11 years ago Actions
Copy link
 #6

  • Target version changed from CB 2.0.8 to CB 2.0.9

Updated by beat about 11 years ago Actions
Copy link
 #7

  • Target version changed from CB 2.0.9 to CB 2.0.10

Updated by beat about 11 years ago Actions
Copy link
 #8

  • Target version changed from CB 2.0.10 to CB 2.0.11

Updated by beat almost 11 years ago Actions
Copy link
 #9

  • Target version changed from CB 2.0.11 to CB 2.0.12

Updated by beat almost 11 years ago Actions
Copy link
 #10

  • Target version changed from CB 2.0.12 to CB 2.0.13

Updated by beat over 10 years ago Actions
Copy link
 #11

  • Target version changed from CB 2.0.13 to CB 2.0.14

Updated by beat over 10 years ago Actions
Copy link
 #12

  • Target version changed from CB 2.0.14 to CB 2.0.15

Updated by beat almost 10 years ago Actions
Copy link
 #13

  • Target version changed from CB 2.0.15 to CB 2.1

Updated by krileon over 9 years ago Actions
Copy link
 #14

  • Target version changed from CB 2.1 to CB 2.2

Updated by krileon about 8 years ago Actions
Copy link
 #15

  • Target version changed from CB 2.2 to CB 2.8

Updated by beat over 3 years ago Actions
Copy link
 #16

  • Target version changed from CB 2.8 to CB 2.8.1

Updated by beat almost 3 years ago Actions
Copy link
 #17

  • Target version changed from CB 2.8.1 to CB 2.8.2

Updated by beat almost 3 years ago Actions
Copy link
 #18

  • Target version changed from CB 2.8.2 to CB 2.9.0

Updated by beat almost 3 years ago Actions
Copy link
 #19

  • Target version changed from CB 2.9.0 to CB 2.9.2

Updated by beat about 2 years ago Actions
Copy link
 #20

  • Target version changed from CB 2.9.2 to CB 2.9.3

Updated by beat almost 2 years ago Actions
Copy link
 #21

  • Target version changed from CB 2.9.3 to CB 2.10.0

Updated by beat over 1 year ago Actions
Copy link
 #22

  • Target version changed from CB 2.10.0 to CB 2.11.0

Updated by beat 10 months ago Actions
Copy link
 #23

  • Target version changed from CB 2.11.0 to CB 2.11.1

Updated by krileon about 1 month ago Actions
Copy link
 #24

  • Status changed from Feedback to Rejected
  • Target version deleted (CB 2.11.1)
  • % Done changed from 0 to 100

None issue at this point. As strings are moved into Joomla language files they'll be given unique keys.

Actions
Copy link

Also available in: PDF Atom