Project

General

Profile

Actions

Bug #6314

closed

Datetime redisplay incrementing by 1 hour

Added by krileon almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Immediate
Assignee:
Target version:
Start date:
23 November 2016
Due date:
% Done:

100%

Estimated time:

Description

Appears DST isn't functioning right when offseting a datetime. For example 05:00:00 UTC is 00:00:00 EST, but redisplay is outputting 01:00:00. Either the JS or the PHP is off.

Actions #1

Updated by krileon almost 8 years ago

Seams to be PHP doing this. The offset is reporting as -05:00 fine, but it's outputting -04:00.

Actions #2

Updated by krileon almost 8 years ago

This appears to be due to out of date timezone data in PHP. This may not affect all installs, but the accuracy issue is gone when converted to a GMT offset.

Actions #3

Updated by krileon almost 8 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Fixed in MR !1179

Converts timezone name to more accurate GMT offset.

Actions #4

Updated by krileon almost 8 years ago

  • Status changed from Resolved to Assigned
  • % Done changed from 100 to 90

Needs further testing to ensure no bad timezone errors occur.

Actions #5

Updated by krileon almost 8 years ago

  • % Done changed from 90 to 0

This happens if you select a date during DST while outside of DST. The PHP handles TimeZone correctly, but momentjs doesn't. The only way for momentjs to properly handle timezone is to include momentjs-timezone.

Actions #6

Updated by krileon almost 8 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Fixed in MR !1179

Implements usage of moment-timezone.

Actions #7

Updated by krileon almost 8 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF