Project

General

Profile

Actions

Bug #6400

closed

External links being used for Itemid

Added by krileon almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
29 December 2016
Due date:
% Done:

100%

Estimated time:

Description

When grabbing the Itemid for a view external links are being checked. This probably isn't correct and the query should strictly be checking component URLs only. Review also migrating such URLs to internal URLs if possible.

https://www.joomlapolis.com/forum/146-general/235587-editing-a-user-profile-in-front-end-leads-to-edit-own-admin-profile#289390

Actions #1

Updated by beat almost 8 years ago

External links was the recommended method in Joomla 1.5 and CB 1.x when there was no other easy way.

So, old installations have plenty of those, and and I don't see any reasons they shouldn't be migrated too to internal links where such options exist, and to new URLs in all cases.

At some point we need to get completely rid of task=...

Actions #2

Updated by timstohr almost 8 years ago

beat wrote:

External links was the recommended method in Joomla 1.5 and CB 1.x when there was no other easy way.

So, old installations have plenty of those, and and I don't see any reasons they shouldn't be migrated too to internal links where such options exist, and to new URLs in all cases.

At some point we need to get completely rid of task=..

Actions #3

Updated by timstohr almost 8 years ago

Sorry guys, just found out that I can apparently edit anything on the forge.... Just wanted to try it out and it worked...

Actions #4

Updated by krileon almost 8 years ago

So, old installations have plenty of those, and and I don't see any reasons they shouldn't be migrated too to internal links where such options exist, and to new URLs in all cases.

External links are migrated as best as possible. This is done as per #6389. Not all can be migrated though, but will be adding more migration with the changes made for this ticket. The changes made for this ticket will be to match exactly how Joomla handles the com_content component.

At some point we need to get completely rid of task=...

It's already gone and has been since CB 2.0. The only trace of task left is converting it to view when it's supplied for B/C. Old installs that never updated their menu items are strictly the problem here. Joomla does not parse external menu items when SEF is enabled.

Sorry guys, just found out that I can apparently edit anything on the forge.... Just wanted to try it out and it worked...

Edit is how you add comments. It's not user friendly here, but it's not really intended to be as it's just our issue tracker. You do not have permissions to edit the actual ticket though or at least shouldn't.

Actions #6

Updated by krileon almost 8 years ago

Looks like the Itemid should still be set in the URL, but the SEF handling needs to act as if it didn't find a menu item for alias usage. This is how core Joomla is doing it for all of its components and appears to be working when done this way. The problem is broken external URLs have the component database value set and this appears to happen when you create an internal CB menu item then change it to external the component value is then set. Will add an additional check to the router to just ignore menu items that are not type = component for SEF purposes, which solves that issue entirely.

Actions #7

Updated by krileon almost 8 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Fixed in MR !1222

Actions #8

Updated by krileon almost 8 years ago

  • Target version changed from CB 2.2 to CB 2.1.1
Actions #9

Updated by beat almost 8 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF