Added by krileon over 13 years ago. Updated about 13 years ago.
Description
There is PHP protection for max length, but when editing the field you've no idea that max length is present until you attempt to save. For fields that support it the attribute "maxlength" should be added.
Files
| 3537.patch (767 Bytes) 3537.patch | krileon, 25 May 2012 15:11 | ||
| 3537_rev1.patch (1.14 KB) 3537_rev1.patch | krileon, 25 June 2012 21:30 |
Updated by krileon over 13 years ago
Actions
#1
Bug only affected textarea fields. Text fields have the attribute applied fine.
Updated by krileon over 13 years ago
Actions
#2
Updated by beat over 13 years ago
Actions
#3
Text area input fields do not have such an attribute in XHTML.
So this patch is not applicable.
Updated by krileon over 13 years ago
Actions
#4
maxlength is a valid attribute for HTML5 and as I understand the default Joomla template (Beez5) in addition to a lot of 3rd parties are releasing HTML5. Alternative is a JS based implementation or simply removing the parameter all together (would be better then having users find out after POST they input too many characters, that'd be frustrating); actually, shouldn't there be a validation rule for jQuery validation to handle maxlength?
Updated by beat over 13 years ago
Actions
#5
Updated by krileon over 13 years ago
Actions
#6
Rev1 adds a validation rule for the textarea for maxlength when using new validation method (default). This will at least inform the user before they attempt to submit that they've surpassed the maximum.
Updated by beat about 13 years ago
Actions
#7
r1891 implements both fixes as proposed, so that old and new browsers should be happy.
Thank you Kyle.
Updated by beat about 13 years ago
Actions
#8
r1909 reverts broken Javascript part of fix of r1891:
CB mass-mailing on Joomlapolis was broken by this.
HTML 5 part of fix is enough here.