Added by krileon about 13 years ago. Updated about 13 years ago.
Description
When pulling variables from GET with SEF enabled on Joomla 3.0 it'll always return nothing as GET is being completely emptied by Joomla before CB is reached. This completely breaks _getAbsURLwithParam wherever used (profilebook/profilegallery for example).
Files
| 3754.patch (458 Bytes) 3754.patch | krileon, 30 October 2012 18:26 | ||
| router.php.patch (503 Bytes) router.php.patch | krileon, 30 October 2012 19:05 | ||
| 3754_rev1.patch (820 Bytes) 3754_rev1.patch | krileon, 30 October 2012 19:08 |
Updated by krileon about 13 years ago
Actions
#1
$_GET = array_merge( array_diff( $_REQUEST, $_POST ), $_GET );
The above works in CBs router file of function comprofilerBuildRoute.
Updated by krileon about 13 years ago
Actions
#2
This is due to JRequest::set($result, 'get', false); being removed from function route in JApplication.
Updated by krileon about 13 years ago
Actions
#3
This entire usage is depreciated. Joomla 3.0 strictly uses $_REQUEST only.
Updated by krileon about 13 years ago
Actions
#4
Attached is my proposed fix to Joomla. Aside from this the JInput would need to be improved to handle this. Only $_REQUEST is passed by reference when using the input api and if you pass a new source it won't be by reference and you'd lose any other existing $_GET variables.
Updated by beat about 13 years ago
Actions
#5
That fix will be rejected.
Fix should IMHO not be in the use of def() but in the def() function itself, with $_GET being assigned at same time as $_REQUEST internally.
Updated by krileon about 13 years ago
Actions
#6
Patch to apply a fix to CBs router by preparing $_GET and $_REQUEST from $vars.
Updated by krileon about 13 years ago
Actions
#7
Rev1 patch implements a data2 only in cases where $_REQUEST is used. This is simply to prepare $_GET when def is used in case of $_REQUEST.
Updated by beat about 13 years ago
Actions
#8
After discussion, Joomla JInput is broken by design as it does not distinguish between $_GET and $_POST and $_COOKIE.
So fix is in CB router.php to fix that design bug of JInput.
r1873 implements and fixes that.