Project

General

Profile

Actions

Bug #4836

open

Some plugins admin language strings are still in front-end language file

Added by beat over 9 years ago. Updated 5 months ago.

Status:
Assigned
Priority:
Normal
Assignee:
Target version:
Start date:
05 November 2014
Due date:
% Done:

0%

Estimated time:

Description

See MR !651

line 1041 of language.php has string:

'INPUT_COMMA_SEPARATED_LIST_OF_INTERNAL_CATEGORIES__7180a6' => 'Input comma separated list of internal categories (e.g. General,Movies,Family).',

which got changed in MR !650 on line 63 in file components/com_comprofiler/plugin/user/plug_cbblogs/cbblogs.xml

and is the description attribute:

<param name="blog_categories" type="text" default="General,Movies,Music,Games,Sports" size="40" label="Categories" description="Input comma separated list of internal categories (e.g. General,Movies,Family)." />

xml description attribute should end in the admin.language.php file, and not in language.php file during strings parsing.


Files

be-patch.diff (54.5 KB) be-patch.diff nant, 07 November 2014 14:44
fe-patch.diff (44.9 KB) fe-patch.diff nant, 07 November 2014 14:44
Actions #1

Updated by beat over 9 years ago

  • Description updated (diff)
Actions #2

Updated by nant over 9 years ago

  • Status changed from Assigned to Feedback
  • Assignee changed from nant to beat

The list of parsed files is listed in the cb->build->tools->languageparser->readme.md file and is the following:

awk -v title='Community Builder (TM) Default (English) language file Frontend' \
-v copyright='(C) 2004-2014 www.joomlapolis.com / Lightning MultiCom SA - and its licensors, all rights reserved' \
-v outfilename='components/com_comprofiler/plugin/language/default_language/language.php' \
-v comment='WARNING:\n* Do not make changes to this file as it will be over-written when you upgrade CB.\n* To localize you need to create your own CB language plugin and make changes there.' \
-f build/tools/languageparser/languageparser.awk \
libraries/CBLib/CB/Application/*.php \
libraries/CBLib/CB/Database/*.php \
libraries/CBLib/CB/Legacy/*.php \
libraries/CBLib/CB/Database/Table/*.php \
libraries/CBLib/CBLib/*/*.php \
libraries/CBLib/CBLib/*/*/*.php \
libraries/CBLib/CBLib/*/*/*/*.php \
libraries/CBLib/Imagine/*/*.php \
libraries/CBLib/Imagine/*/*/*.php \
administrator/components/com_comprofiler/comprofiler.class.php \
administrator/components/com_comprofiler/plugin.class.php \
administrator/components/com_comprofiler/plugin.foundation.php \
components/com_comprofiler/*.php \
components/com_comprofiler/*.xml \
components/com_comprofiler/plugin/user/*/*.php \
components/com_comprofiler/plugin/user/*/*.xml \
components/com_comprofiler/plugin/user/*/*/*.php \
components/com_comprofiler/plugin/user/*/*/*/*.php \
components/com_comprofiler/plugin/templates/*/*.php \
components/com_comprofiler/views/*/*.xml \
components/com_comprofiler/views/*/*/*.php \
modules/mod_cblogin/*.php \
modules/mod_cblogin/*/*.php \
modules/mod_comprofilermoderator/*.php \
modules/mod_comprofilermoderator/*/*.php \
modules/mod_comprofileronline/*.php \
modules/mod_comprofileronline/*/*.php \
plugins/communitybuilder/*.php \
plugins/communitybuilder/*.xml \
build/tools/languageparser/languageparser.awk \
administrator/components/com_comprofiler/*.xml \
administrator/components/com_comprofiler/xmlcb/*.xml \
administrator/components/com_comprofiler/xmlcb/*/*.xml \
components/com_comprofiler/plugin/user/*/*/*.xml \
components/com_comprofiler/plugin/user/*/*/*/*.xml

tell me what changes I need to make and I will make them.

Actions #3

Updated by beat over 9 years ago

  • Assignee changed from beat to nant

Don't think it's an use issue, more like a bug in the language parser awk tool: the xml file reported above is after the delimiter, and its description attributes should not go into language.php file.

Actions #4

Updated by beat over 9 years ago

Ah seen now that the line

components/com_comprofiler/plugin/user/*/*.xml \

should probably go above:
components/com_comprofiler/plugin/user/*/*/*.xml \

. That would effect that admin side settings string of plugins stop being loaded into frontend.

Updated by nant over 9 years ago

If I move the parsing of

components/com_comprofiler/plugin/user/*/*.xml

then there are lots of changes that happen.

see attached diffs.

Actions #6

Updated by krileon over 9 years ago

Field and Tab strings are in those XML files, which are for frontend. IMO the parsing should stay frontend. The alternative is to have specific parsing for tab and field nodes for frontend and the rest be treated like backend (the default attribute frontend parsing still would need to apply).

Actions #7

Updated by beat over 9 years ago

  • Assignee changed from beat to krileon

Wondering how many such FE strings are defined that way (comparded to the large number of long sentences that get translated and loaded in front-end unneededly).

If not too many, would make sense to define them in a way that they are taken by FE part too.

Either by defining them elsewehere (too), or by adding a translation-specific attribute for the language-parser to pick them up for front-end ?

Actions #8

Updated by krileon over 9 years ago

  • Target version changed from CB 2.0.3 to CB 2.0.4
Actions #9

Updated by krileon over 9 years ago

  • Assignee changed from krileon to beat

I assume a plugins XML file can be given the same backend default attribute treatment. The parsing would need to be tested and see if the output is expected.

Actions #10

Updated by beat over 9 years ago

  • Status changed from Feedback to Assigned
  • Assignee changed from beat to nant

Agree, Kyle.

Reassigning to Nick so that language parser can be updated and plugins re-parsed..

Actions #11

Updated by beat over 9 years ago

  • Target version changed from CB 2.0.4 to CB 2.0.5
Actions #12

Updated by beat about 9 years ago

  • Target version changed from CB 2.0.5 to CB 2.0.6
Actions #13

Updated by beat about 9 years ago

  • Target version changed from CB 2.0.6 to CB 2.0.7
Actions #14

Updated by beat about 9 years ago

  • Target version changed from CB 2.0.7 to CB 2.0.8
Actions #15

Updated by beat almost 9 years ago

  • Target version changed from CB 2.0.8 to CB 2.0.9
Actions #16

Updated by beat almost 9 years ago

  • Target version changed from CB 2.0.9 to CB 2.0.10
Actions #17

Updated by beat almost 9 years ago

  • Target version changed from CB 2.0.10 to CB 2.0.11
Actions #18

Updated by beat over 8 years ago

  • Target version changed from CB 2.0.11 to CB 2.0.12
Actions #19

Updated by beat over 8 years ago

  • Target version changed from CB 2.0.12 to CB 2.0.13
Actions #20

Updated by beat about 8 years ago

  • Target version changed from CB 2.0.13 to CB 2.0.14
Actions #21

Updated by beat about 8 years ago

  • Target version changed from CB 2.0.14 to CB 2.0.15
Actions #22

Updated by beat over 7 years ago

  • Target version changed from CB 2.0.15 to CB 2.1
Actions #23

Updated by krileon over 7 years ago

  • Target version changed from CB 2.1 to CB 2.2
Actions #24

Updated by krileon almost 6 years ago

  • Target version changed from CB 2.2 to CB 2.8
Actions #25

Updated by beat about 1 year ago

  • Target version changed from CB 2.8 to CB 2.8.1
Actions #26

Updated by beat 8 months ago

  • Target version changed from CB 2.8.1 to CB 2.8.2
Actions #27

Updated by beat 7 months ago

  • Target version changed from CB 2.8.2 to CB 2.9.0
Actions #28

Updated by beat 5 months ago

  • Target version changed from CB 2.9.0 to CB 2.9.2
Actions

Also available in: Atom PDF