Bug #4836: Some plugins admin language strings are still in front-end language file - CB - Joomlapolis forge

Actions

Copy link

Bug #4836

open

Some plugins admin language strings are still in front-end language file

Added by beat about 10 years ago. Updated 4 months ago.

Status:

Assigned

Priority:

Normal

Assignee:

nant

Target version:

CB 2.9.4

Start date:

05 November 2014

Due date:

% Done:

Estimated time:

Description

See MR !651

line 1041 of language.php has string:

'INPUT_COMMA_SEPARATED_LIST_OF_INTERNAL_CATEGORIES__7180a6' => 'Input comma separated list of internal categories (e.g. General,Movies,Family).',

which got changed in MR !650 on line 63 in file components/com_comprofiler/plugin/user/plug_cbblogs/cbblogs.xml

and is the description attribute:

<param name="blog_categories" type="text" default="General,Movies,Music,Games,Sports" size="40" label="Categories" description="Input comma separated list of internal categories (e.g. General,Movies,Family)." />

xml description attribute should end in the admin.language.php file, and not in language.php file during strings parsing.

Files

Download all files

be-patch.diff (54.5 KB) be-patch.diff		nant, 07 November 2014 14:44
fe-patch.diff (44.9 KB) fe-patch.diff		nant, 07 November 2014 14:44

Actions

Copy link

Updated by beat about 10 years ago

Description updated (diff)

Actions

Copy link

Updated by nant about 10 years ago

Status changed from Assigned to Feedback
Assignee changed from nant to beat

The list of parsed files is listed in the cb->build->tools->languageparser->readme.md file and is the following:

awk -v title='Community Builder (TM) Default (English) language file Frontend' \
-v copyright='(C) 2004-2014 www.joomlapolis.com / Lightning MultiCom SA - and its licensors, all rights reserved' \
-v outfilename='components/com_comprofiler/plugin/language/default_language/language.php' \
-v comment='WARNING:\n* Do not make changes to this file as it will be over-written when you upgrade CB.\n* To localize you need to create your own CB language plugin and make changes there.' \
-f build/tools/languageparser/languageparser.awk \
libraries/CBLib/CB/Application/*.php \
libraries/CBLib/CB/Database/*.php \
libraries/CBLib/CB/Legacy/*.php \
libraries/CBLib/CB/Database/Table/*.php \
libraries/CBLib/CBLib/*/*.php \
libraries/CBLib/CBLib/*/*/*.php \
libraries/CBLib/CBLib/*/*/*/*.php \
libraries/CBLib/Imagine/*/*.php \
libraries/CBLib/Imagine/*/*/*.php \
administrator/components/com_comprofiler/comprofiler.class.php \
administrator/components/com_comprofiler/plugin.class.php \
administrator/components/com_comprofiler/plugin.foundation.php \
components/com_comprofiler/*.php \
components/com_comprofiler/*.xml \
components/com_comprofiler/plugin/user/*/*.php \
components/com_comprofiler/plugin/user/*/*.xml \
components/com_comprofiler/plugin/user/*/*/*.php \
components/com_comprofiler/plugin/user/*/*/*/*.php \
components/com_comprofiler/plugin/templates/*/*.php \
components/com_comprofiler/views/*/*.xml \
components/com_comprofiler/views/*/*/*.php \
modules/mod_cblogin/*.php \
modules/mod_cblogin/*/*.php \
modules/mod_comprofilermoderator/*.php \
modules/mod_comprofilermoderator/*/*.php \
modules/mod_comprofileronline/*.php \
modules/mod_comprofileronline/*/*.php \
plugins/communitybuilder/*.php \
plugins/communitybuilder/*.xml \
build/tools/languageparser/languageparser.awk \
administrator/components/com_comprofiler/*.xml \
administrator/components/com_comprofiler/xmlcb/*.xml \
administrator/components/com_comprofiler/xmlcb/*/*.xml \
components/com_comprofiler/plugin/user/*/*/*.xml \
components/com_comprofiler/plugin/user/*/*/*/*.xml

tell me what changes I need to make and I will make them.

Actions

Copy link

Updated by beat about 10 years ago

Assignee changed from beat to nant

Don't think it's an use issue, more like a bug in the language parser awk tool: the xml file reported above is after the delimiter, and its description attributes should not go into language.php file.

Actions

Copy link

Updated by beat about 10 years ago

Ah seen now that the line

components/com_comprofiler/plugin/user/*/*.xml \

should probably go above:
components/com_comprofiler/plugin/user/*/*/*.xml \

. That would effect that admin side settings string of plugins stop being loaded into frontend.

Actions

Copy link Download all files

Updated by nant about 10 years ago

File be-patch.diff be-patch.diff added
File fe-patch.diff fe-patch.diff added
Assignee changed from nant to beat

If I move the parsing of

components/com_comprofiler/plugin/user/*/*.xml

then there are lots of changes that happen.

see attached diffs.

Actions

Copy link

Updated by krileon about 10 years ago

Field and Tab strings are in those XML files, which are for frontend. IMO the parsing should stay frontend. The alternative is to have specific parsing for tab and field nodes for frontend and the rest be treated like backend (the default attribute frontend parsing still would need to apply).

Actions

Copy link

Updated by beat about 10 years ago

Assignee changed from beat to krileon

Wondering how many such FE strings are defined that way (comparded to the large number of long sentences that get translated and loaded in front-end unneededly).

If not too many, would make sense to define them in a way that they are taken by FE part too.

Either by defining them elsewehere (too), or by adding a translation-specific attribute for the language-parser to pick them up for front-end ?

Actions

Copy link

Updated by krileon about 10 years ago

Target version changed from CB 2.0.3 to CB 2.0.4

Actions

Copy link

Updated by krileon about 10 years ago

Assignee changed from krileon to beat

I assume a plugins XML file can be given the same backend default attribute treatment. The parsing would need to be tested and see if the output is expected.

Actions

Copy link

#10