Bug #2960
closed
CB 1.7.1 substitution check uses language string value instead of stored field value
Added by nant about 13 years ago.
Updated almost 13 years ago.
Start date:
06 November 2011
Files
- Status changed from New to Assigned
- Assignee set to krileon
- Target version set to CB 1.8
The translation is done in PHP mode in cb.core.php line 737 and 742 of r1650 . Maybe those should be not translated. Affects all uses of the getField, so needs a review.
The only getField usage where PHP output is used is in the substitutions. Seams safe to remove the translation of values for PHP getField usage.
- File 2960.patch 2960.patch added
- Status changed from Assigned to Resolved
- Assignee changed from krileon to beat
- % Done changed from 0 to 100
Further review it appears that select fields are the only fields where the values are translated for PHP output, all the others output raw.
Noticed PHP and CSV had same formatting changes; rev1 added to just use it.
- Status changed from Resolved to Closed
- Estimated time set to 2:00 h
Thanks.
Fixed in r1722 .
Kept code, with check for $reason finishing with ":translated", that way maybe some uses in substitutions will work like e.g. : reason="profile:translated" for those fields.
Ohterwise falling through like suggested to csv method.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by